Fix mps deployment #505
Merged
Fix mps deployment #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only deploy the MPS daemonset if the deviceplugin is deployed. Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
elezar
requested review from
tariq1890,
ArangoGutierrez,
cdesiniotis and
shivamerla
cdesiniotis
reviewed
Feb 12, 2024
| @@ -186,7 +186,6 @@ spec: | |||
| # This is required for CDI detection to work correctly. | |||
| - name: driver-root | |||
| mountPath: /driver-root | |||
| readOnly: true | |||
There was a problem hiding this comment.
Question -- why is this no longer read only?
There was a problem hiding this comment.
The issue is that the mount to /driver-root/mps fails if this is a readonly path.
Do you have suggestions on how we can get around this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deployed without MPS enabled, the device plugin fails due to mounts not being creatable.