Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[no-relnote] Bump NFD Helm chart to v0.16.6 #1025

Merged
merged 2 commits into from
Nov 11, 2024
Merged

[no-relnote] Bump NFD Helm chart to v0.16.6 #1025

merged 2 commits into from
Nov 11, 2024

Conversation

ArangoGutierrez
Copy link
Collaborator

No description provided.

@ArangoGutierrez
[no-relnote] Manually bump NFD version
e3cdeb9 
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
@ArangoGutierrez ArangoGutierrez self-assigned this Oct 30, 2024
@ArangoGutierrez ArangoGutierrez mentioned this pull request Oct 30, 2024
Merged
@elezar
Copy link
Member

elezar commented Oct 31, 2024

Do we need to bump the package versions as part of this as well? How does NFD handle that kind of drift?

@ArangoGutierrez
Copy link
Collaborator Author

Do we need to bump the package versions as part of this as well? How does NFD handle that kind of drift?

I think we need to bump this deps manually to enable Dependabot. because #1007 just tells dependabot to track NFD again and it will fail

@elezar
Copy link
Member

elezar commented Oct 31, 2024

Do we need to bump the package versions as part of this as well? How does NFD handle that kind of drift?

I think we need to bump this deps manually to enable Dependabot. because #1007 just tells dependabot to track NFD again and it will fail

That wasn't my question. My question was whether we NEED to also update the client, or can a v0.15.x client talk to a v0.16.x server?

@ArangoGutierrez
Copy link
Collaborator Author

Do we need to bump the package versions as part of this as well? How does NFD handle that kind of drift?

I think we need to bump this deps manually to enable Dependabot. because #1007 just tells dependabot to track NFD again and it will fail

That wasn't my question. My question was whether we NEED to also update the client, or can a v0.15.x client talk to a v0.16.x server?

Oh, sorry, yeah NFD API is stable, NodeFeature and NodeFeatureRules API's haven't changed during these releases

@ArangoGutierrez ArangoGutierrez changed the title [no-relnote] Manually bump NFD version [no-relnote] Bump NFD Helm chart Oct 31, 2024
@elezar elezar changed the title [no-relnote] Bump NFD Helm chart [no-relnote] Bump NFD Helm chart to v0.16.6 Oct 31, 2024
@ArangoGutierrez
Copy link
Collaborator Author

This PR now is just about HELM

@ArangoGutierrez
Copy link
Collaborator Author

@elezar PTAL

@elezar elezar merged commit 23334f7 into NVIDIA:main Nov 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elezar elezar elezar approved these changes

Assignees

@ArangoGutierrez ArangoGutierrez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArangoGutierrez @elezar