Bump sigs.k8s.io/node-feature-discovery to v0.16.6 #1023
Conversation
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
|
As discussed we can now revert #1007 |
I don't agree. Dependabot doesn't update helm subcharts and only updates go imports in this context. Note that since the packages have been moved in NFD between v0.15.x and v0.16.x we would expect to have to update these manually. |
elezar
changed the title
go.mod
Outdated
| @@ -24,7 +24,8 @@ require ( | |||
| k8s.io/klog/v2 v2.130.1 | |||
| k8s.io/kubelet v0.31.1 | |||
| k8s.io/mount-utils v0.31.1 | |||
| sigs.k8s.io/node-feature-discovery v0.15.4 | |||
| sigs.k8s.io/node-feature-discovery v0.16.6 | |||
| sigs.k8s.io/node-feature-discovery/api/nfd v0.0.0-20241030145326-d13729bfa450 | |||
There was a problem hiding this comment.
@ArangoGutierrez note that the api/nfd go submodule is not properly versioned and as such will ALWAYS have a pseuto version.
One also needs to specify an explicit SHA when running go mod get -- otherwise the SHA off HEAD of master will be retrieved.
There was a problem hiding this comment.
It seems that we need to cut a tag for the submodule
There was a problem hiding this comment.
Yes: see, for example https://github.com/cncf-tags/container-device-interface/tags
Signed-off-by: Evan Lezar <[email protected]> Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
ArangoGutierrez
force-pushed
the
revert1007
branch
from
b89f02c to
4fe51dc
Compare
This change reverts #1007 and bumps the NFD client packages to v0.16.6.