Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull data review preparations into dev #194

Merged
merged 11 commits into from
Dec 13, 2024
Merged

Pull data review preparations into dev #194

merged 11 commits into from
Dec 13, 2024

Conversation

BBeltz1
Copy link
Collaborator

@BBeltz1 BBeltz1 commented Dec 13, 2024

Updates to the following datasets:

  • ecosystem overfishing (ppr)
  • seasonal_oisst_anom_gridded
  • trans_dates

Added comparison documents for use in the leads data review

Remove the polynomial fit from geom_gls

Added short term trend analysis to the following plot functions:

  • plot_commercial_div.Rd
  • plot_ichthyo_diversity.Rd
  • plot_nao.Rd
  • plot_ne_inshore_survey.Rd
  • plot_observed_sharks.Rd
  • plot_slopewater.Rd
  • plot_wcr.Rd
  • plot_wind_revenue.Rd

@BBeltz1 BBeltz1 requested review from sgaichas and andybeet December 13, 2024 18:59
@BBeltz1 BBeltz1 self-assigned this Dec 13, 2024
@BBeltz1 BBeltz1 linked an issue Dec 13, 2024 that may be closed by this pull request
Please install short term trend on plot functions not using geom_gls because they are <30 years #176
Open
@BBeltz1
Copy link
Collaborator Author

BBeltz1 commented Dec 13, 2024

Closes #176

@BBeltz1
Copy link
Collaborator Author

BBeltz1 commented Dec 13, 2024

@andybeet @sgaichas This PR contains mostly preparation for yesterday's data review. There are a few data updates, geom_lm has been added to several plots, the poly fit was turned off in geom_gls and there's a large batch of comparison docs, which were shown yesterday. This shouldn't need major review, as everything in this PR was reviewed yesterday and any issues have been flagged as an action item or Github issue. That said, please let me know if you notice anything needing immediate attention.

andybeet
andybeet approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@andybeet andybeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

sgaichas
sgaichas approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@sgaichas sgaichas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok here, didn't test much

@sgaichas sgaichas merged commit 8222238 into dev Dec 13, 2024
7 checks passed
@sgaichas
Copy link
Member

When I pulled this in there was a gitleaks fail
https://github.com/NOAA-EDAB/ecodata/actions/runs/12323766236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andybeet andybeet andybeet approved these changes

@sgaichas sgaichas sgaichas approved these changes

Assignees

@BBeltz1 BBeltz1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please install short term trend on plot functions not using geom_gls because they are <30 years
3 participants
@BBeltz1 @sgaichas @andybeet