Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please install short term trend on plot functions not using geom_gls because they are <30 years #176

Open
sgaichas opened this issue Nov 18, 2024 · 2 comments · Fixed by #194
Assignees

Comments

@sgaichas
Copy link
Member

As noted in #165 (comment) some plot functions have geom_gls commented out. This is likely because they have fewer than 30 years of data to plot. For datasets that don't meet the length criterion for using geom_gls, we do want the option of using geom_lm.

So far this applies to the commercial diversity datasets that I have seen, but there are others.

@BBeltz1 BBeltz1 self-assigned this Nov 19, 2024
@BBeltz1
Copy link
Collaborator

BBeltz1 commented Dec 11, 2024

I've completed another sweep of the indicators and added short term trend analysis to the following:

  • plot_commercial_div
  • plot_ichthyo_diversity
  • plot_nao
  • plot_ne_inshore_survey
  • plot_observed_sharks
  • plot_slopewater
  • plot_wcr
  • plot_wind_revenue

@BBeltz1
Copy link
Collaborator

BBeltz1 commented Dec 11, 2024

There may still be others, so please let me know if you notice any other plots you want short term trend applied to. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants