Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: initial save/read paired dataset support for melodies-monet run #202

Merged
merged 3 commits into from
Nov 15, 2023
Merged

CLI: initial save/read paired dataset support for melodies-monet run #202

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a6a7b3
cli: initial save/read support
zmoon Mar 4, 2023
35ea288
consistency
zmoon Oct 25, 2023
b588ebe
Separate idealized save/read cases for testing CLI
zmoon Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion melodies_monet/_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,14 @@ def run(
an.open_obs()

with _timer("Pairing"):
Copy link
Collaborator Author

@zmoon zmoon Oct 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe should have separate message for each case here, for clarity ("Reading saved paired datasets" vs "Pairing")

Copy link
Collaborator Author

@zmoon zmoon Oct 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh but I guess the file names are already printed when reading

an.pair_data()
if an.read is not None:
an.read_analysis()
else:
an.pair_data()

if an.save is not None:
with _timer("Saving paired datasets"):
an.save_analysis()

if an.control_dict.get("plots") is not None:
with _timer("Plotting and saving the figures"), _ignore_pandas_numeric_only_futurewarning():
Expand Down
Loading