-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: initial save/read paired dataset support for melodies-monet run
#202
Conversation
@@ -146,7 +146,14 @@ def run( | |||
an.open_obs() | |||
|
|||
with _timer("Pairing"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe should have separate message for each case here, for clarity ("Reading saved paired datasets" vs "Pairing")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh but I guess the file names are already printed when reading
melodies-monet run
linkcheck failed for https://www3.epa.gov/ttn/naaqs/standards/ozone/data/20140131healthrea4a.pdf, which is indeed currently unreachable In the idealized config CLI test run, getting permission denied for saving the file:
I guess this is because it has that file open, which was created when running the idealized example nb. So may have to create separate configs for writing/reading. Update: fixed in |
@rschwant @colin-harkins can one of you take a look at this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Thanks for making a test for this.
analysis.read
is present in the config, read saved paired datasets instead of pairinganalysis.save
is present in the config, save paired datasetsThis is something I've been using for a while, and it's been working fine.