Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: initial save/read paired dataset support for melodies-monet run #202

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

zmoon
Copy link
Collaborator

@zmoon zmoon commented Oct 25, 2023

  1. if analysis.read is present in the config, read saved paired datasets instead of pairing
  2. if analysis.save is present in the config, save paired datasets

This is something I've been using for a while, and it's been working fine.

@@ -146,7 +146,14 @@ def run(
an.open_obs()

with _timer("Pairing"):
Copy link
Collaborator Author

@zmoon zmoon Oct 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe should have separate message for each case here, for clarity ("Reading saved paired datasets" vs "Pairing")

Copy link
Collaborator Author

@zmoon zmoon Oct 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh but I guess the file names are already printed when reading

@zmoon zmoon changed the title CLI: initial save/read paired dataset support CLI: initial save/read paired dataset support for melodies-monet run Oct 25, 2023
@zmoon
Copy link
Collaborator Author

zmoon commented Oct 25, 2023

linkcheck failed for https://www3.epa.gov/ttn/naaqs/standards/ozone/data/20140131healthrea4a.pdf, which is indeed currently unreachable

In the idealized config CLI test run, getting permission denied for saving the file:

 Writing: ./output/idealized/asdf_test_obs_test_model.nc4
Saving paired datasets failed in 0.209 seconds
Error message: [Errno 13] Permission denied: '/home/runner/work/MELODIES-MONET/MELODIES-MONET/docs/examples/output/idealized/asdf_test_obs_test_model.nc4'

I guess this is because it has that file open, which was created when running the idealized example nb. So may have to create separate configs for writing/reading.

Update: fixed in b588ebe

@bbakernoaa
Copy link
Collaborator

@rschwant @colin-harkins can one of you take a look at this

@bbakernoaa bbakernoaa added the enhancement New feature or request label Nov 9, 2023
Copy link
Collaborator

@colin-harkins colin-harkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for making a test for this.

@zmoon zmoon merged commit ed57dab into NOAA-CSL:develop Nov 15, 2023
4 checks passed
@zmoon zmoon deleted the cli branch November 15, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants