Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gradle deprecations #5153

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Gradle deprecations #5153

merged 3 commits into from
Oct 26, 2023

Conversation

soloturn
Copy link
Contributor

@soloturn soloturn commented Oct 26, 2023 •
edited
Loading

send @PurityLake #5140 again, cherry picked to tip of develop branch and thus conflicts resolved, and @BenjaminAmos comments addressed.

@soloturn
Copy link
Contributor Author

@jdrueckert this time i messaged in discord, in general dev topics, terasology :)

@soloturn
gradle warnings, integrate review comments from BenjaminAmos
ec81b2b 
cherry picked PurityLakes pr MovingBlocks#5140
onto newest develop. kotlin plugin and spotbugs conflict comments are resolved
by this.

protobuf upgrade should be compabitle, at least according to documentation, so
left it there.  the lenient in module_deps.kt is again there.
@soloturn soloturn force-pushed the gradle-deprecations branch from 03ad298 to ec81b2b Compare October 26, 2023 06:55
@jdrueckert
Copy link
Member

jdrueckert commented Oct 26, 2023 •
edited
Loading

@jdrueckert this time i messaged in discord, in general dev topics, terasology :)

Yup, just saw that, thank you 👍 And look at that, you got three people's attention in less than a day 😁
@BenjaminAmos mentioned on Discord that he's on it so I'll leave you(r PR) in his very capable hands 🙂

BenjaminAmos
BenjaminAmos approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@BenjaminAmos BenjaminAmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes all seem fairly minor and harmless.

Upgrading protobuf hopefully should not break server compatibility but I don't think we've ever guarenteed compatibility between game versions anyway. If we're going to break it, now's the time to do it.

@BenjaminAmos
Copy link
Contributor

One of the integration tests has failed (ExampleTest.testClientConnection()), so I'm going to try and re-run that to unblock merging. It looks like random failure, rather than a regression.

@BenjaminAmos BenjaminAmos merged commit 07176f7 into MovingBlocks:develop Oct 26, 2023
8 checks passed
@soloturn soloturn mentioned this pull request Oct 26, 2023
Closed
@soloturn soloturn deleted the gradle-deprecations branch October 28, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminAmos BenjaminAmos BenjaminAmos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@soloturn @jdrueckert @BenjaminAmos @PurityLake