Skip to content

Commit

Permalink
gradle warnings, integrate review comments from BenjaminAmos
Browse files Browse the repository at this point in the history
cherry picked PurityLakes pr #5140
onto newest develop. kotlin plugin and spotbugs conflict comments are resolved
by this.

protobuf upgrade should be compabitle, at least according to documentation, so
left it there.

the lenient in module_deps.kt is again there:
```
val artifactView = resolvable.artifactView {
  lenient(true)
}
```
  • Loading branch information
soloturn committed Oct 26, 2023
1 parent 5938af4 commit 03ad298
Showing 1 changed file with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,9 @@ fun moduleDependencyOrdering(modulesConfig: Configuration): List<String> {
// configurations.resolvedConfiguration is more straightforward if you just want all the artifacts,
// but using `.incoming` lets us turn on lenient mode as well as do more accurate filtering of local modules
val resolvable = modulesConfig.incoming
val artifactView = resolvable.artifactView {
lenient(true)
}

val result = resolvable.resolutionResult
val allDependencies = result.allDependencies
Expand Down

0 comments on commit 03ad298

Please sign in to comment.