Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing extensions #79

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Add missing extensions #79

merged 3 commits into from
Nov 22, 2024

Conversation

kghbln
Copy link
Contributor

@kghbln kghbln commented Nov 20, 2024

  • Create Page
  • Page Approvals
  • Persistent Page Identifiers

@kghbln
Copy link
Contributor Author

kghbln commented Nov 20, 2024

@hexmode Probably fails since not submodule was added. However, I have no clue how to do so. Any guidance is appreciated.

@hexmode
Copy link
Member

hexmode commented Nov 20, 2024

  1. Fork the repo and check out a copy.
  2. In your copy of the repo, add a submodule pointing to the repo you want to add. Something like git submodule add REPO_URL SUB_DIR where REPO_URL is the git url and SUB_DIR is subdirectory where the repo's checkout should appear.
  3. (Not strictly necessary, but appreciated) Edit .gitmodules so that the repository appears in the order that it should. If you edit the file, don't forget to git add .gitmodules so your changes are in the commit.
  4. Commit your changes and push to your fork.
  5. Create a pull request to be merged.

Thanks!

@kghbln
Copy link
Contributor Author

kghbln commented Nov 21, 2024

Thanks a bunch for your help. Still failing due to unmet policy. It looks like Pickle is at fault. :|

@hexmode
Copy link
Member

hexmode commented Nov 21, 2024

No, the policy is telling you that you didn't put PersistentPageIdentifiers in the right order. It should go after PeriodicRelatedChanges. This should really be an automated fix, but if you could update your branch, I'd appreciate it.

@kghbln
Copy link
Contributor Author

kghbln commented Nov 21, 2024

That explains why I could not pickle the extensions into this repo—senior moments. Thanks for your help. Much appreciated!

@hexmode hexmode merged commit 1253f80 into MWStake:master Nov 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants