Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry sync v2 - API #167

Conversation

thecatcore
Copy link
Member

New registry api, more extensible, only handles registry infrastructure (remapping included).

Individual registries for content are moved to their own module in other pr depending on this one.

build.gradle Outdated Show resolved Hide resolved
@thecatcore thecatcore self-assigned this May 9, 2024
@thecatcore thecatcore added enhancement New feature or request help wanted Extra attention is needed new module New module bikeshed yes draft labels May 9, 2024
@thecatcore thecatcore force-pushed the feature/registry-sync-v2/api branch from d9996b3 to 3a74c69 Compare August 29, 2024 20:22
@thecatcore thecatcore marked this pull request as ready for review August 29, 2024 20:22
@thecatcore thecatcore removed the draft label Aug 29, 2024
@thecatcore thecatcore added this to the 1.11.0 milestone Aug 29, 2024
…nc-v2/api

# Conflicts:
#	legacy-fabric-registry-sync-api-v1/1.7.10/src/main/resources/registrysync.accesswidener
#	legacy-fabric-registry-sync-api-v1/1.8/src/main/resources/registrysync.accesswidener
#	legacyfabric-api/1.10.2/src/testmod/java/net/legacyfabric/fabric/test/registry/RegistryTest.java
#	legacyfabric-api/1.11.2/src/testmod/java/net/legacyfabric/fabric/test/registry/RegistryTest.java
#	legacyfabric-api/1.12.2/src/testmod/java/net/legacyfabric/fabric/test/registry/RegistryTest.java
#	legacyfabric-api/1.7.10/src/testmod/java/net/legacyfabric/fabric/test/registry/RegistryTest.java
#	legacyfabric-api/1.8.9/src/testmod/java/net/legacyfabric/fabric/test/registry/RegistryTest.java
#	legacyfabric-api/1.8/src/testmod/java/net/legacyfabric/fabric/test/registry/RegistryTest.java
@thecatcore thecatcore added MC1.8.9 Related to Minecraft 1.8.9 MC1.8 Related to Minecraft 1.8 MC1.7.10 Related to Minecraft 1.7.10 MC1.9.4 Related to Minecraft 1.9.4 MC1.10.2 Related to Minecraft 1.10.2 MC1.11.2 Related to Minecraft 1.11.2 MC1.12.2 Related to Minecraft 1.12.2 labels Nov 29, 2024
Copy link
Contributor

@ENDERZOMBI102 ENDERZOMBI102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Naming seems correct too

@thecatcore thecatcore merged commit 0524871 into Legacy-Fabric:feature/registry-sync-v2/main Dec 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bikeshed yes enhancement New feature or request help wanted Extra attention is needed MC1.7.10 Related to Minecraft 1.7.10 MC1.8 Related to Minecraft 1.8 MC1.8.9 Related to Minecraft 1.8.9 MC1.9.4 Related to Minecraft 1.9.4 MC1.10.2 Related to Minecraft 1.10.2 MC1.11.2 Related to Minecraft 1.11.2 MC1.12.2 Related to Minecraft 1.12.2 new module New module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants