Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry sync v2 - Item #168

Open
wants to merge 17 commits into
base: feature/registry-sync-v2/main
Choose a base branch
from

Conversation

thecatcore
Copy link
Member

@thecatcore thecatcore commented Mar 23, 2024

What does this module do:

  • Register vanilla Item registry into Registry sync v2 system
  • Set item translation key from identifier when registering it
  • [NEW] Fix item models not being associated with the right item after registry was remapped
  • [NEW] For 1.7.10, provide a transitive access widener for the method getFromId, allowing devs to set texture location more easily.

@thecatcore thecatcore self-assigned this May 9, 2024
@thecatcore thecatcore added enhancement New feature or request help wanted Extra attention is needed new module New module bikeshed yes draft and removed help wanted Extra attention is needed labels May 9, 2024
@thecatcore thecatcore force-pushed the feature/registry-sync-v2/item branch from 12cd75d to b06bd86 Compare August 29, 2024 20:37
@thecatcore thecatcore marked this pull request as ready for review August 29, 2024 21:11
@thecatcore thecatcore added this to the 1.11.0 milestone Aug 29, 2024
@thecatcore thecatcore marked this pull request as draft August 29, 2024 21:23
@thecatcore thecatcore force-pushed the feature/registry-sync-v2/item branch from 9988cde to ac40bb7 Compare December 22, 2024 13:06
@thecatcore thecatcore force-pushed the feature/registry-sync-v2/item branch from ac40bb7 to ed2566e Compare December 22, 2024 13:10
@thecatcore thecatcore marked this pull request as ready for review December 22, 2024 15:44
@thecatcore thecatcore added MC1.8.9 Related to Minecraft 1.8.9 MC1.8 Related to Minecraft 1.8 MC1.7.10 Related to Minecraft 1.7.10 MC1.9.4 Related to Minecraft 1.9.4 MC1.10.2 Related to Minecraft 1.10.2 MC1.11.2 Related to Minecraft 1.11.2 MC1.12.2 Related to Minecraft 1.12.2 and removed draft labels Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bikeshed yes enhancement New feature or request MC1.7.10 Related to Minecraft 1.7.10 MC1.8 Related to Minecraft 1.8 MC1.8.9 Related to Minecraft 1.8.9 MC1.9.4 Related to Minecraft 1.9.4 MC1.10.2 Related to Minecraft 1.10.2 MC1.11.2 Related to Minecraft 1.11.2 MC1.12.2 Related to Minecraft 1.12.2 new module New module
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant