Fix unneccessary copy and query in animatior.h #407
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The auto keyword in C++ will drop the reference and top level const in the type deduction.
The following code at animator.h line 57 will cause boneInfoMap be implicitly copied from the animation's member variable.
Since the CalculateBoneTransform is implemented in the recursive fashion, every access to the animation node in the node tree hierarchy will implicitly copy the boneInfoMap, which may cause performance issue.
Besides, we can save the boneInfoMap query result, instead of querying it three times