Add monkeypatch for group definitions to fix jurigged bug #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add monkeypatch for group definition
JamesHutchison
commented
Nov 30, 2023
Comment on lines
-145
to
151
| if delta > 0: | ||
| if delta != 0: | ||
| self.recode(jurigged_utils.shift_lineno(co, delta), use_cache=False) |
There was a problem hiding this comment.
While debugging I noticed this case and found that delta could be negative. It looked like the negative value, with the off-by-one fix, was correct, so that is why this changed to !=
|
It would be better that this was fixed in jurigged. I noticed the author was active very recently so I'll bring up these concerns there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jurigged is adding a blank line between things. It's not clear to me why. This creates a bug where the line numbers diverge from reality.
This PR also improves the explanations for the monkey patches.