Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation around jurigged monkeypatch and add tests that prove value #54

Open
JamesHutchison opened this issue Nov 30, 2023 · 2 comments

Comments

@JamesHutchison
Copy link
Owner

The jurigged monkeypatch is insufficiently documented. It does two functions:

  • Applies the assertion rewrites from pytest when a function is updated
  • Fixes an off-by-one issue

The PR that added the monkeypatch and assertion rewrites came first and is here:
#15

The PR that fixes the off by one is here:
#32

I'd need to double check, but IIRC the off-by-one was somewhat prevalent. When the line numbers are wrong, the varname library used by MegaPatch.it can't find things (due to looking in the wrong spot) and those break. Additionally, the wrong line numbers can break debugger behavior because things stop lining up.

@JamesHutchison
Copy link
Owner Author

It's also been many months, it might be time to add some issues to the jurigged library.

@JamesHutchison
Copy link
Owner Author

Comments were improved in #55

I'm wondering if it makes more sense to just get this all fixed in jurigged instead of writing tests for the monkeypatches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant