Added reg cert, fixed hashing of VKeys
#616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soupstraw
force-pushed
the
jj/legacy-regcert
branch
2 times, most recently
from
d61a6c9 to
28742bb
Compare
Soupstraw
force-pushed
the
jj/legacy-regcert
branch
5 times, most recently
from
e26e564 to
6cfba2b
Compare
Soupstraw
force-pushed
the
jj/legacy-regcert
branch
7 times, most recently
from
ae3aaed to
6cc0b86
Compare
Soupstraw
force-pushed
the
jj/legacy-regcert
branch
6 times, most recently
from
a23e50d to
13c6922
Compare
Soupstraw
force-pushed
the
jj/legacy-regcert
branch
4 times, most recently
from
d1d27a1 to
16ba02d
Compare
Soupstraw
force-pushed
the
jj/legacy-regcert
branch
3 times, most recently
from
610d033 to
23218dd
Compare
Merged
9 tasks
Soupstraw
force-pushed
the
jj/legacy-regcert
branch
from
23218dd to
502aee5
Compare
williamdemeo
approved these changes
Dec 4, 2024
|
@Soupstraw before merging, could you please add descriptions for each substantial change to the |
Soupstraw
force-pushed
the
jj/legacy-regcert
branch
from
6a77bbf to
09c9137
Compare
Soupstraw
force-pushed
the
jj/legacy-regcert
branch
from
09c9137 to
68fedc5
Compare
williamdemeo
added a commit
that referenced
this pull request
Dec 6, 2024
Partial attempt to reconcile this branch with the new DELEG-reg rule introduced by [PR 616](#616). (The new rule is introduced [here](https://github.com/IntersectMBO/formal-ledger-specifications/blob/68fedc572770a4cbdca3cb303bead472063688c4/src/Ledger/Certs.lagda#L337-L343).)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
regcert, which behaves similarly todelegate c nothing nothing d, except that it doesn't require witnessing. This is the legacy staking address registration certificate that we still want to support in Conway and hopefully we can get rid of in the future.Adds
HSVKey, which stores the verification key together with the hash that's provided during translation in conformance testing. This fixes the issue where the value of the VKey itself is used as the hash, which caused conformance tests to fail.related: IntersectMBO/cardano-ledger#4780
closes #615
Checklist
CHANGELOG.md