-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues that prevent basic sumbitTx
from passing conformance
#4780
Conversation
sumbitTx
sumbitTx
to pass conformance
d51e83b
to
e96a69b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work figuring out all the really difficult bits! 🙌
eras/shelley/impl/testlib/Test/Cardano/Ledger/Shelley/ImpTest.hs
Outdated
Show resolved
Hide resolved
a313c14
to
29ef9fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 🙌
99bb31e
to
48d9c03
Compare
sumbitTx
to pass conformancesumbitTx
from passing conformance
55def05
to
badaac8
Compare
libs/cardano-ledger-conformance/test/Test/Cardano/Ledger/Conformance/Imp/Ratify.hs
Show resolved
Hide resolved
...cardano-ledger-conformance/src/Test/Cardano/Ledger/Conformance/ExecSpecRule/Conway/Ledger.hs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
cc855cb
to
c4bb012
Compare
Description
This PR fixes some issues that prevent the conformance tests on most of the ImpTests from passing.
The
VKey
type is now translated to a pair of theVKey
and the hash of thatVKey
, similar to howTimelock
s are translated.ConwayRegCert
now translates to theReg
certificate, which is a newly added certificate in the spec. The previous approach of translating that cert toDeleg
did not work, because theDeleg
cert always requires witnessing, while the legacy registration cert does not.related: IntersectMBO/formal-ledger-specifications#616
Checklist
CHANGELOG.md
for the affected packages.New section is never added with the code changes. (See RELEASING.md)
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated.If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)