Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues that prevent basic sumbitTx from passing conformance #4780

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Dec 4, 2024

Description

This PR fixes some issues that prevent the conformance tests on most of the ImpTests from passing.

The VKey type is now translated to a pair of the VKey and the hash of that VKey, similar to how Timelocks are translated.

ConwayRegCert now translates to the Reg certificate, which is a newly added certificate in the spec. The previous approach of translating that cert to Deleg did not work, because the Deleg cert always requires witnessing, while the legacy registration cert does not.

related: IntersectMBO/formal-ledger-specifications#616

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Soupstraw Soupstraw changed the title Fix issues that prevent basicsumbitTx Fix issues that prevent basic sumbitTx to pass conformance Dec 4, 2024
@Soupstraw Soupstraw marked this pull request as ready for review December 4, 2024 13:36
@Soupstraw Soupstraw requested a review from a team as a code owner December 4, 2024 13:36
Copy link
Contributor

@aniketd aniketd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work figuring out all the really difficult bits! 🙌

@Soupstraw Soupstraw force-pushed the jj/conformance-fix branch 2 times, most recently from a313c14 to 29ef9fa Compare December 4, 2024 13:57
Copy link
Contributor

@aniketd aniketd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🙌

@Soupstraw Soupstraw force-pushed the jj/conformance-fix branch 5 times, most recently from 99bb31e to 48d9c03 Compare December 4, 2024 14:34
@Soupstraw Soupstraw changed the title Fix issues that prevent basic sumbitTx to pass conformance Fix issues that prevent basic sumbitTx from passing conformance Dec 4, 2024
@Soupstraw Soupstraw requested review from teodanciu and lehins December 4, 2024 14:35
@Soupstraw Soupstraw force-pushed the jj/conformance-fix branch 3 times, most recently from 55def05 to badaac8 Compare December 5, 2024 12:37
@Soupstraw Soupstraw enabled auto-merge (squash) December 5, 2024 12:38
@Soupstraw Soupstraw disabled auto-merge December 5, 2024 12:38
@Soupstraw Soupstraw enabled auto-merge (rebase) December 5, 2024 12:39
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Soupstraw Soupstraw merged commit d99e0cd into master Dec 6, 2024
153 of 154 checks passed
@Soupstraw Soupstraw deleted the jj/conformance-fix branch December 6, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants