-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IS filters performances plot #144
Conversation
Reviewer's Guide by SourceryThis pull request introduces several enhancements and refactors to the ShakeTune module, focusing on improving the performance plots for input shaper filters. Key changes include the addition of new constants, refactoring of the File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Frix-x - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 7 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
WIP
Summary by Sourcery
This pull request enhances the input shaper calibration tool by adding new plotting features for maximum vibrations and smoothing tests. It also refactors the calibration process for better compatibility and improves the overall layout and information display in the plots. Additionally, the ShakeTune initialization and command registration processes have been streamlined and improved.