Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move any hardcoded variables to constants #36

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

refactor: move any hardcoded variables to constants #36

wants to merge 15 commits into from
+245 −147

Conversation

alepouna
Copy link
Member

Description

EXTENSIVE TESTING REQUIRED!

  • Moves all hardcoded variables (e.g. embed colors, channels IDs, etc.) to a new file 'constants.ts' for better organization and preventing miss-matches from forgotten variables.
  • Command files linting (removes unused vars)
  • Add node types to package.json as it was missing

@alepouna alepouna requested a review from Dynamic6448 July 26, 2024 15:49
@alepouna alepouna mentioned this pull request Jul 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dynamic6448 Dynamic6448 Awaiting requested review from Dynamic6448

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alepouna