Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: prevent q-and-a channel from being used as a commands channel #35

Merged
merged 1 commit into from
Dec 19, 2024
Merged

feat: prevent q-and-a channel from being used as a commands channel #35

merged 1 commit into from
Dec 19, 2024

Conversation

alepouna
Copy link
Member

No description provided.

@alepouna alepouna added the enhancement New feature or request label Jul 25, 2024
@alepouna alepouna requested a review from Dynamic6448 July 25, 2024 22:10
@alepouna
Copy link
Member Author

reminder: after #36 merges, follow up PR needed to move hard-coded constants to constants file

Dynamic6448
Dynamic6448 requested changes Aug 3, 2024
View reviewed changes
Copy link
Member

@Dynamic6448 Dynamic6448 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code/functionality wise looks good, but instead of putting it directly in the main index.ts file, create a new utility in src/utils to handle this

@alepouna alepouna requested a review from Dynamic6448 December 19, 2024 18:34
@alepouna alepouna merged commit ed51045 into Digital-Flight-Dynamics:master Dec 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dynamic6448 Dynamic6448 Dynamic6448 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alepouna @Dynamic6448