Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't rewrite volatile sentinel config file #172

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

joshbenner
Copy link

@joshbenner joshbenner commented Sep 21, 2017

This PR tries to address the issue of Sentinel (and redis-server) writing its state back to its own config file using a couple of measures:

  1. Splits sentinel and server configs into a volatile and static (included) files
  2. Writes a script that updates the running Sentinel with monitor configuration

In my testing, this results in idempotent configuration that should survive changes. It's not perfect -- it won't remove monitors that are no longer around, but it's a step in the right direction by not always rewriting sentinel's config file (or a sentinel-managed redis server config that is managed by sentinel).

This might be enough to fix #22?

@DavidWittman DavidWittman added this to the 2.0 milestone Oct 13, 2017
@DavidWittman
Copy link
Owner

Thanks @joshbenner! These changes are excellent and have been sorely needed in this role for quite while. I'll do some testing around this PR and add it to the 2.0 milestone.

@tleguern
Copy link

Do you know when this PR can be fully tested and merged and is there something I can do to help you with it? This change is watched with interest at my job.

@Rylon
Copy link

Rylon commented Oct 25, 2018

@DavidWittman +1 for merging, we could really use it on my team. Any idea on the timeframe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic selection of master
4 participants