Don't rewrite volatile sentinel config file #172
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to address the issue of Sentinel (and redis-server) writing its state back to its own config file using a couple of measures:
In my testing, this results in idempotent configuration that should survive changes. It's not perfect -- it won't remove monitors that are no longer around, but it's a step in the right direction by not always rewriting sentinel's config file (or a sentinel-managed redis server config that is managed by sentinel).
This might be enough to fix #22?