Role idempotency, fixed deprecations, flush_handlers warning, updated checksums #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhiljalagam
approved these changes
Oct 30, 2019
|
Hello, I'm interested in seeing this merged. It's been here for over a year. Is there anyway I can help move this along? |
misdoro
reviewed
Oct 14, 2020
| @@ -44,7 +37,7 @@ | |||
| home: "{{ redis_install_dir }}" | |||
| shell: /bin/false | |||
| system: yes | |||
| when: user_exists|failed | |||
| state: present | |||
There was a problem hiding this comment.
There is a risk here of setting the shell to /bin/false of a login user, if for any reason redis_user is set to anything else but redis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some deprecations (with_items, using tests as filters)
Updated checksums
Idempotent implementation for log file creation tasks (avoid using touch)
Idempotent implementation for config file tasks (make Ansible check for configuration changes in a reference configuration file instead of the real one - which is dynamically rewritten by redis). This is similar to Don't rewrite volatile sentinel config file #172 .
Removed flush_handlers: it was used with when conditionals but resulted in this warning:
Implemented another workaround to prevent services from starting and then re-starting.
Changed minimum Ansible version to 2.5.0 (older versions are incompatible with loop - and with_items is deprecated)