Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push error events instead of pageloads on error pages #766

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

Charles-Pham
Copy link
Contributor

ADO-297006

Changelog - "fix:" for bug fixes, "feat:" for features. Read more about Conventional Commits at https://www.conventionalcommits.org/en/v1.0.0/#summary

Description of proposed changes:

Simplified AA push and made it push errors on error pages instead of pageloads.

What to test for/How to test

That the app pushes error events on error pages and pageloads on other pages.

Additional Notes

@Charles-Pham Charles-Pham requested a review from a team as a code owner December 2, 2024 23:33
Copy link

github-actions bot commented Dec 2, 2024

Copy link
Contributor

@jhslater jhslater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Charles-Pham Charles-Pham merged commit e83e1f5 into dev Dec 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants