Merge pull request #766 from DTS-STN/aa-error-page

Push error events instead of pageloads on error pages
DTS-STN · Dec 3, 2024 · e83e1f5 · e83e1f5
2 parents 5a0400c + a449bd7
commit e83e1f5
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 13 deletions.
diff --git a/pages/404.tsx b/pages/404.tsx
@@ -71,6 +71,7 @@ export const getStaticProps: GetStaticProps = async ({ locale }) => {
       accessRights: '1',
     },
   }
+
   return {
     props: {
       locale,
@@ -80,6 +81,7 @@ export const getStaticProps: GetStaticProps = async ({ locale }) => {
       isAuth: process.env.AUTH_DISABLED ?? true,
       aaPrefix: `ESDC-EDSC_MSCA-MSDC-SCH:404 Error`,
       aaMenuPrefix: `ESDC-EDSC_MSCA-MSDC-SCH:Nav Menu`,
+      errType: '404',
     },
   }
 }

diff --git a/pages/500.tsx b/pages/500.tsx
@@ -80,6 +80,7 @@ export const getStaticProps: GetStaticProps = async ({ locale }) => {
       isAuth: process.env.AUTH_DISABLED ?? true,
       aaPrefix: `ESDC-EDSC_MSCA-MSDC-SCH:500 Error`,
       aaMenuPrefix: `ESDC-EDSC_MSCA-MSDC-SCH:Nav Menu`,
+      errType: '500',
     },
   }
 }

diff --git a/pages/_app.js b/pages/_app.js
@@ -24,22 +24,19 @@ export default function MyApp({ Component, pageProps, router }) {
    *  @see https://github.com/vercel/next.js/blob/canary/examples/with-google-analytics
    * */
   useEffect(() => {
-    const handleRouteChange = () => {
-      // only push event if pathname is different
-      if (window.location.pathname !== appPreviousLocationPathname) {
+    // only push event if pathname is different
+    if (window.location.pathname !== appPreviousLocationPathname) {
+      if (pageProps.errType !== undefined) {
+        window.adobeDataLayer?.push?.({
+          event: 'error',
+          error: pageProps.errType,
+        })
+      } else {
         window.adobeDataLayer?.push?.({ event: 'pageLoad' })
-        appPreviousLocationPathname = window.location.pathname
       }
+      appPreviousLocationPathname = window.location.pathname
     }
-
-    handleRouteChange()
-    router.events.on('routeChangeComplete', handleRouteChange)
-    router.events.on('hashChangeComplete', handleRouteChange)
-    return () => {
-      router.events.off('routeChangeComplete', handleRouteChange)
-      router.events.off('hashChangeComplete', handleRouteChange)
-    }
-  }, [router.events])
+  }, [router.asPath, pageProps.errType])
 
   /* istanbul ignore next */
   return (