Enable trivial cases of global state variables. #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR includes preparatory commits to move some printing code. Which I'd like to split away once accepted. It also includes the generated |
1uc
force-pushed
the
1uc/trivial-global-vars
branch
2 times, most recently
from
9eba6e0 to
59efbf0
Compare
1uc
force-pushed
the
1uc/trivial-global-vars
branch
from
84d38e0 to
3cb7a94
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1130 +/- ##
==========================================
- Coverage 88.31% 88.21% -0.10%
==========================================
Files 175 175
Lines 12981 13024 +43
==========================================
+ Hits 11464 11489 +25
- Misses 1517 1535 +18 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
1uc
force-pushed
the
1uc/trivial-global-vars
branch
from
3cb7a94 to
f118e0d
Compare
This comment has been minimized.
This comment has been minimized.
iomaganaris
reviewed
Jan 9, 2024
This comment has been minimized.
This comment has been minimized.
1uc
force-pushed
the
1uc/trivial-global-vars
branch
from
3255394 to
a6799f9
Compare
This comment has been minimized.
This comment has been minimized.
1uc
force-pushed
the
1uc/trivial-global-vars
branch
from
a6799f9 to
6d14759
Compare
|
Logfiles from GitLab pipeline #185257 (:white_check_mark:) have been uploaded here! Status and direct links: |
iomaganaris
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the functionality required to make trivial cases involving GLOBAL variables work.