Move GLOBAL related code. #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #1130 for context. |
The methods: - print_global_var_struct_decl - print_global_var_struct_assertions - instance_struct - global_struct - global_struct_instance have been moved from the CoreNEURON C++ printer to the shared C++ printer.
1uc
force-pushed
the
1uc/move-global-related-code
branch
from
cf36c0f to
f92d2ee
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1137 +/- ##
==========================================
- Coverage 88.31% 88.31% -0.01%
==========================================
Files 175 175
Lines 12983 12981 -2
==========================================
- Hits 11466 11464 -2
Misses 1517 1517 ☔ View full report in Codecov by Sentry. |
|
Logfiles from GitLab pipeline #184894 (:white_check_mark:) have been uploaded here! Status and direct links: |
iomaganaris
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The methods:
have been moved from the CoreNEURON C++ printer to the shared C++ printer.