Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text: mention that index is required for signing #64

Merged

Conversation

jonasnick
Copy link
Collaborator

Fixes #38

Copy link
Collaborator

@real-or-random real-or-random left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you're suggesting not to change the DKGOutput to include the index, right? Can you elaborate on why not?

README.md Outdated Show resolved Hide resolved
@jonasnick
Copy link
Collaborator Author

So you're suggesting not to change the DKGOutput to include the index, right? Can you elaborate on why not?

Correct. The reason to include the index in the DKG output would be that this would make the DKG output contain sufficient information for signing. However, if the signer wants to initiate a signing session, this DKG output would not be sufficient because the signer needs to know also the indices of the participating signers. Hence, even for that DKG output the signer (and coordinator) would have to have a way to get the index of a particular hostpubkey from the list (if they want to initiate a signing session).

Also, finding the index of a hostpubkey in the list is trivial (and it's in some sense already input of the DKG).

@jesseposner
Copy link

Also, finding the index of a hostpubkey in the list is trivial (and it's in some sense already input of the DKG).

Is this because the ordering of the hostpubkeys in the list determines the index assignment?

@jonasnick
Copy link
Collaborator Author

Yes

@real-or-random
Copy link
Collaborator

real-or-random commented Dec 10, 2024

Also, finding the index of a hostpubkey in the list is trivial (and it's in some sense already input of the DKG).

Okay, that makes sense. Also with the signing BIP in mind, which uses indices instead of arbitrary identifiers.

If the signing BIP were to use arbitrary identifiers instead, we'd probably want to output our choice of identifiers. But if everything uses indices, then it's okay to leave this implicit. (The only caveat is that signing takes as input 32-byte arrays that will be interpreted as integer indices. I think it's a bit more natural to use integers directly, but perhaps this could be changed in the signing BIP)

@real-or-random real-or-random merged commit cc63faa into BlockstreamResearch:master Dec 10, 2024
1 check passed
@real-or-random
Copy link
Collaborator

(The only caveat is that signing takes as input 32-byte arrays that will be interpreted as integer indices. I think it's a bit more natural to use integers directly, but perhaps this could be changed in the signing BIP)

Just noticed that this is tracked in siv2r/bip-frost-signing#9 already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Index assignment
3 participants