-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copter: remove stale parameter conversions #28951
base: master
Are you sure you want to change the base?
Copter: remove stale parameter conversions #28951
Conversation
// PARAMETER_CONVERSION - Added: Jan-2019 | ||
{ "RC8_OPTION", 32 }, | ||
// PARAMETER_CONVERSION - Added: Aug-2018 | ||
// PARAMETER_CONVERSION - Added: Aug-2020 | ||
{ "RC_OPTIONS", 0 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optionally we could probably drop this RC_OPTIONS line too which is from Aug 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optionally we could probably drop this RC_OPTIONS line too which is from Aug 2020
Yeah, I really did consider it. But they I couldn't use the pretty straight-forward 3.6.9 -> 4.x.x argument as to why it was time for these to go away :-)
I was also a little surprised at how much of the conversion code did go away. I wonder if we're doing less of it now-adays...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but @bnsgeyer should approve as well because these are mostly trad heli changes
this removes stale parameter conversions. These patches are all in the Copter-4.0.0 tag, meaning that they are all for upgrading from a version prior to that to a version prior-or-equal-to Copter-4.0.0 Past this a user running a version of ArduCopter < 4.0.0 to something >= 4.7.0 will not have smooth parameter conversions
despite these looking likely to be conversion information, these are actually default values embedded within the Copter::convert_pid_parameters method
a28bf19
to
18772d8
Compare
@rmackay9 I've fixed an error in this PR. Currently in master there's a block of code which is responsible for setting parameter defaults on the heli frame - and it's within a method called I'd like to move that code out in a future PR - it's in the wrong place IMO. Probably move it up, called around the comment "now setup some frame-class specific defaults" |
this removes stale parameter conversions.
These patches are all in the Copter-4.0.0 tag, meaning that they are all for upgrading from a version prior to that to a version prior-or-equal-to Copter-4.0.0
Past this a user running a version of ArduCopter < 4.0.0 to something >= 4.7.0 will not have smooth parameter conversions