Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate lint job #8061

Merged
merged 2 commits into from
Nov 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions .github/workflows/test-all-packages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ jobs:
# We split the package tests into two jobs because type linting
# is inefficient and slow https://github.com/typescript-eslint/typescript-eslint/issues/2094
lint-primary:
timeout-minutes: 15
timeout-minutes: 20
needs: build
runs-on: ubuntu-latest
steps:
Expand All @@ -91,22 +91,19 @@ jobs:
with:
node-version: '18.x'

# first job also does repo-level linting
- name: lint repo format
run: yarn lint:format
# eslint
- name: yarn lint primary
run: ./scripts/lint-with-types.sh primary
# eslint and tsc
- run: yarn lint:packages
# build the API docs to verify it works
- name: build API docs
run: yarn docs
# build the API docs in markdown for agoric/documentation repo to verify it works
- name: build API docs in markdown
run: yarn docs:markdown-for-agoric-documentation-repo

# A second job for what's not covered in primary
lint-rest:
timeout-minutes: 15
needs: build
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand All @@ -117,8 +114,6 @@ jobs:
# Check some of a3p-integration in this job that runs on PRs instead of
# waiting for the slow integration test that by default only runs in the
# master merge check
- name: yarn lint rest of packages/*
run: ./scripts/lint-with-types.sh rest
- name: Lint a3p-integration
run: yarn install && yarn lint && yarn doctor
working-directory: a3p-integration
Expand Down
22 changes: 0 additions & 22 deletions scripts/lint-with-types.sh

This file was deleted.

Loading