consolidate lint job #8061
Merged
consolidate lint job #8061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iomekam
approved these changes
Jul 19, 2023
kriskowal
approved these changes
Jul 19, 2023
|
I'm exploring ways I can land this without churn on people's branch protection checks. Also I've seen it working sometimes in my IDE so I'm exploring whether we can enable this always (remove the option) |
turadg
force-pushed
the
ta/consolidate-lint
branch
from
5b0f61f to
c414a25
Compare
turadg
force-pushed
the
ta/consolidate-lint
branch
from
c414a25 to
3cad269
Compare
Deploying agoric-sdk with
|
| Latest commit: |
a1d4261
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e3d212e0.agoric-sdk.pages.dev |
| Branch Preview URL: | https://ta-consolidate-lint.agoric-sdk.pages.dev |
turadg
force-pushed
the
ta/consolidate-lint
branch
from
3cad269 to
28cd6e5
Compare
turadg
force-pushed
the
ta/consolidate-lint
branch
from
28cd6e5 to
a325ace
Compare
turadg
force-pushed
the
ta/consolidate-lint
branch
from
a325ace to
a1d4261
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no issue
Description
#8058 made linting with types fast enough to enable again. It's even fast enough now that the splitting doesn't save any time.
This gets rid of the
lint-with-types.shscript that managed the splitting. The CI job now just runsyarn lint. Doing that required that each package'syarn lintcommand has types enabled, so it does that too.An upshot is that now running
yarn lintlocally will check no-floating-promises, even though the IDE still doesn't.Security Considerations
n/a
Scaling Considerations
n/a
Documentation Considerations
reduces need to document
Testing Considerations
CI.
Once it passes, someone will have to update branch protections to remove the split primary/rest requirements.When this PR started there wasn't a point to two jobs, but now the second job covers a3p-integration so it's worth keeping