Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An embarrassment which we hope to discuss only rarely but that satisfies the ne… #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

An embarrassment which we hope to discuss only rarely but that satisfies the ne… #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added images/milky-way-map-with-alaska.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/milky-way-map.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/top-1701-a.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/top-1701-b.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/top-1701-c.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
29 changes: 28 additions & 1 deletion pages/about.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,35 @@
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Document</title>
<link href="../style/style.css" rel="stylesheet">
</head>
<body>


<nav class="nav">
<ul>
<li>NAVIGATION</li>
<li><a href=../pages/index.html> home </a></li>
<li><a href=../pages/portfolio.html> - portfolio - </a></li>
<li><a href=../pages/about.html> about </a></li>
</ul>
Comment on lines +13 to +18
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of ul!

</nav>

<header class="header">
<h1>ABOUT</h1>
<p class="text-center">I am from Alaska.</p>
<!-- <p><img class="container" src="../images/milky-way-map.png" alt="A map of the milky way from Wikipedia."></p> -->
<p class="container card">
<img src="../images/milky-way-map.png" alt="A map of the Milky Way from Wikipedia.">
<img src="../images/milky-way-map-with-alaska.png" class="img-top" alt="The same map of the Milky Way from before, edited to show Alaska's position.">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of alt text! Also a very funny picture 😛

</p>
</header>

<footer class="footer">
<ul>
<li>FOOTER</li>
<li>Some Things Before You Go</li>
</ul>
</footer>

</body>
</html>
31 changes: 30 additions & 1 deletion pages/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,37 @@
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Document</title>
<link href="../style/style.css" rel="stylesheet">
</head>

<body>

<nav class="nav">
<ul>
<li>NAV<li>
<li><a href =../pages/index.html> home </a></li>
<li><a href =../pages/portfolio.html> - portfolio - </a></li>
<li><a href =../pages/about.html> about </a></li>
</ul>
</nav>

<header class="header">
<ul>
<li>HOME</li>
<li>These images are arranged using a grid containers.</li>
</ul>
<ul class = "grid-container">
<li><img class = "li-image" src = "../images/top-1701-a.png" alt = "top view of saucer portion of USS Enterprise NCC-1701"></li>
<li><img class = "li-image" src = "../images/top-1701-b.png" alt = "top view of saucer portion of USS Enterprise NCC-1701-B"></li>
<li><img class = "li-image" src = "../images/top-1701-c.png" alt = "top view of saucer portion of USS Enterprise NCC-1701-C"></li>
</ul>
Comment on lines +26 to +30
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good grid here!

</header>

<footer class="footer">
<ul>
<li>FOOTER</li>
<li>Some Things Before You Go</li>
</ul>
</footer>

</body>
</html>
30 changes: 30 additions & 0 deletions pages/portfolio.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,38 @@
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Document</title>
<link href="../style/style.css" rel="stylesheet">
</head>

<body>

<nav class="nav">
<ul>
<li>NAV</li>
<li><a href =../pages/index.html> home </a></li>
<li><a href =../pages/portfolio.html> - portfolio - </a></li>
<li><a href =../pages/about.html> about </a></li>
</ul>
</nav>


<header class="header">
<ul>
<li>PORTFOLIO</li>
<li>Here they are again, but with a flex-grid.</li>
<li><img class="flex-container" src = "../images/top-1701-a.png" alt = "top view of saucer portion of USS Enterprise NCC-1701">
<img class="flex-container" src = "../images/top-1701-b.png" alt = "top view of saucer portion of USS Enterprise NCC-1701-B">
<img class="flex-container" src = "../images/top-1701-c.png" alt = "top view of saucer portion of USS Enterprise NCC-1701-C">
Comment on lines +27 to +29
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These don't actually end up in a flexbox. We would need display:grid styling on the li element to make this work.

</li>
</ul>
</header>

<footer class="footer">
<ul>
<li>FOOTER</li>
<li>Some Things Before You Go</li>
</ul>
</footer>

</body>
</html>
83 changes: 83 additions & 0 deletions style/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@

.center-text {
text-align:center;
}

.container {
/* these are just an arbitrary widths and heights to look good on our browser */
width: 100%;
height: 100%;
vertical-align: middle;
}

.grid-container {
display: grid;
grid-template-columns: 1fr 1fr 1fr;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of fractional units!

align-content:center;

}

.li-image{
height:300px
}

/* .gridcontainer {
display: grid;
grid-template-columns: 1fr 1fr 1fr;
grid-auto-rows: minmax(100px, auto);
grid-template-areas:
". header header ."
"main main main main"
". footer footer .";
} */

.header {
background-color: #7128a2;
text-align: center;
font-size: large;
display: flex;
flex-direction: column;
flex-wrap: wrap;
vertical-align: middle;

}

.nav {
text-align:center;
background-color: #f0e442;
}

.content {
background-color: #009e73;
}

.footer {
background-color: #0072b2;
text-align:center;
font-size: small;
display: flex;
flex-direction: column
}

.card {
vertical-align: middle;
position: relative;
display: flex;
}
.card .img-top {
display: none;
position: absolute;
top: 0;
left: 0;
z-index: 99;
}
.card:hover .img-top {
display: inline;
}

.flex-container {


height: 300px;

}