An embarrassment which we hope to discuss only rarely but that satisfies the ne… #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cessicary conditions of the project at hand
alope107
reviewed
Dec 21, 2021
There was a problem hiding this comment.
Nice job Kit! My apologies it took me so long to give you feedback on this. Your grid worked well here, but I think some of your flex boxes didn't get applied as you intended. This is something we can definitely continue to practice with your future front-end work!
Comment on lines
+13
to
+18
| <ul> | ||
| <li>NAVIGATION</li> | ||
| <li><a href=../pages/index.html> home </a></li> | ||
| <li><a href=../pages/portfolio.html> - portfolio - </a></li> | ||
| <li><a href=../pages/about.html> about </a></li> | ||
| </ul> |
| <!-- <p><img class="container" src="../images/milky-way-map.png" alt="A map of the milky way from Wikipedia."></p> --> | ||
| <p class="container card"> | ||
| <img src="../images/milky-way-map.png" alt="A map of the Milky Way from Wikipedia."> | ||
| <img src="../images/milky-way-map-with-alaska.png" class="img-top" alt="The same map of the Milky Way from before, edited to show Alaska's position."> |
There was a problem hiding this comment.
Nice use of alt text! Also a very funny picture 😛
|
|
||
| .grid-container { | ||
| display: grid; | ||
| grid-template-columns: 1fr 1fr 1fr; |
Comment on lines
+26
to
+30
| <ul class = "grid-container"> | ||
| <li><img class = "li-image" src = "../images/top-1701-a.png" alt = "top view of saucer portion of USS Enterprise NCC-1701"></li> | ||
| <li><img class = "li-image" src = "../images/top-1701-b.png" alt = "top view of saucer portion of USS Enterprise NCC-1701-B"></li> | ||
| <li><img class = "li-image" src = "../images/top-1701-c.png" alt = "top view of saucer portion of USS Enterprise NCC-1701-C"></li> | ||
| </ul> |
Comment on lines
+27
to
+29
| <li><img class="flex-container" src = "../images/top-1701-a.png" alt = "top view of saucer portion of USS Enterprise NCC-1701"> | ||
| <img class="flex-container" src = "../images/top-1701-b.png" alt = "top view of saucer portion of USS Enterprise NCC-1701-B"> | ||
| <img class="flex-container" src = "../images/top-1701-c.png" alt = "top view of saucer portion of USS Enterprise NCC-1701-C"> |
There was a problem hiding this comment.
These don't actually end up in a flexbox. We would need display:grid styling on the li element to make this work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cessicary conditions of the project at hand
Personal Portfolio Site
Congratulations! You're submitting your assignment!
Comprehension Questions