-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branches - Kelsey #36
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -7,39 +7,83 @@ def initialize | |||||||
@head = nil | ||||||||
end | ||||||||
|
||||||||
# Time complexity - ? | ||||||||
# Space complexity - ? | ||||||||
# Time complexity - O(1) | ||||||||
# Space complexity - O(1), thanks to the power of linked lists we are not making any new data structures, just one new node. | ||||||||
def add_first(data) | ||||||||
|
||||||||
node = Node.new(data, @head) | ||||||||
@head = node | ||||||||
return @head.data | ||||||||
end | ||||||||
|
||||||||
# Time complexity - ? | ||||||||
# Space complexity - ? | ||||||||
# Time complexity - O(1) | ||||||||
# Space complexity - O(1) | ||||||||
def get_first | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||||||||
|
||||||||
return @head.data if @head | ||||||||
end | ||||||||
|
||||||||
# Time complexity - ? | ||||||||
# Space complexity - ? | ||||||||
# Time complexity - O(n), where n is the length of the list | ||||||||
# Space complexity - O(1) | ||||||||
def length | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 This works, but could be simplified a bit. |
||||||||
return 0 | ||||||||
count = 0 | ||||||||
if @head | ||||||||
next_node = @head.next | ||||||||
count += 1 | ||||||||
while next_node != nil | ||||||||
count += 1 | ||||||||
next_node = next_node.next | ||||||||
end | ||||||||
end | ||||||||
return count | ||||||||
end | ||||||||
|
||||||||
# Time complexity - ? | ||||||||
# Space complexity - ? | ||||||||
# Time complexity - O(n) | ||||||||
# Space complexity - O(1) | ||||||||
def add_last(data) | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 This works, but it could be simplified a bit. |
||||||||
|
||||||||
if @head | ||||||||
if @head.next | ||||||||
next_node = @head.next | ||||||||
until next_node.next == nil | ||||||||
next_node = next_node.next | ||||||||
end | ||||||||
next_node.next = Node.new(data) | ||||||||
else | ||||||||
@head.next = Node.new(data) | ||||||||
end | ||||||||
else | ||||||||
@head = Node.new(data) | ||||||||
end | ||||||||
end | ||||||||
|
||||||||
# Time complexity - ? | ||||||||
# Space complexity - ? | ||||||||
# Time complexity - O(n) | ||||||||
# Space complexity - O(1) | ||||||||
def get_last | ||||||||
|
||||||||
if @head.next | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What if
Suggested change
|
||||||||
last_node = @head.next | ||||||||
while last_node.next != nil | ||||||||
last_node = last_node.next | ||||||||
end | ||||||||
return last_node.data | ||||||||
elsif @head | ||||||||
return @head.data | ||||||||
else | ||||||||
return nil | ||||||||
end | ||||||||
end | ||||||||
|
||||||||
# Time complexity - ? | ||||||||
# Space complexity - ? | ||||||||
# Time complexity - O(n), where `n` = index | ||||||||
# Space complexity - O(1) | ||||||||
def get_at_index(index) | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What about if the index is greater than the length of the list? |
||||||||
|
||||||||
if @head.nil? | ||||||||
return nil | ||||||||
else | ||||||||
index = index | ||||||||
node_index = 0 | ||||||||
next_node = @head | ||||||||
until node_index == index || next_node == nil | ||||||||
node_index += 1 | ||||||||
next_node = next_node.next | ||||||||
end | ||||||||
return next_node.data | ||||||||
end | ||||||||
end | ||||||||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍