Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branches - Kelsey #36

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 62 additions & 18 deletions lib/linked_list.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,39 +7,83 @@ def initialize
@head = nil
end

# Time complexity - ?
# Space complexity - ?
# Time complexity - O(1)
# Space complexity - O(1), thanks to the power of linked lists we are not making any new data structures, just one new node.
def add_first(data)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


node = Node.new(data, @head)
@head = node
return @head.data
end

# Time complexity - ?
# Space complexity - ?
# Time complexity - O(1)
# Space complexity - O(1)
def get_first

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


return @head.data if @head
end

# Time complexity - ?
# Space complexity - ?
# Time complexity - O(n), where n is the length of the list
# Space complexity - O(1)
def length

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This works, but could be simplified a bit.

return 0
count = 0
if @head
next_node = @head.next
count += 1
while next_node != nil
count += 1
next_node = next_node.next
end
end
return count
end

# Time complexity - ?
# Space complexity - ?
# Time complexity - O(n)
# Space complexity - O(1)
def add_last(data)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This works, but it could be simplified a bit.


if @head
if @head.next
next_node = @head.next
until next_node.next == nil
next_node = next_node.next
end
next_node.next = Node.new(data)
else
@head.next = Node.new(data)
end
else
@head = Node.new(data)
end
end

# Time complexity - ?
# Space complexity - ?
# Time complexity - O(n)
# Space complexity - O(1)
def get_last

if @head.next

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if head is nil?

Suggested change
if @head.next
return nil if @head.nil?
if @head.next

last_node = @head.next
while last_node.next != nil
last_node = last_node.next
end
return last_node.data
elsif @head
return @head.data
else
return nil
end
end

# Time complexity - ?
# Space complexity - ?
# Time complexity - O(n), where `n` = index
# Space complexity - O(1)
def get_at_index(index)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about if the index is greater than the length of the list?


if @head.nil?
return nil
else
index = index
node_index = 0
next_node = @head
until node_index == index || next_node == nil
node_index += 1
next_node = next_node.next
end
return next_node.data
end
end
end
8 changes: 4 additions & 4 deletions test/linked_list_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
end
end

xdescribe 'add_first & get_first' do
describe 'add_first & get_first' do
it 'can add values to an empty list' do
# Act
@list.add_first(3)
Expand Down Expand Up @@ -51,7 +51,7 @@
end
end

xdescribe "length" do
describe "length" do
it "will return 0 for an empty list" do
expect(@list.length).must_equal 0
end
Expand All @@ -66,7 +66,7 @@
end
end

xdescribe "addLast & getLast" do
describe "addLast & getLast" do
it "will add to the front if the list is empty" do
@list.add_last(1)
expect(@list.get_first).must_equal 1
Expand All @@ -91,7 +91,7 @@

end

xdescribe 'get_at_index' do
describe 'get_at_index' do
it 'returns nil if the index is outside the bounds of the list' do
expect(@list.get_at_index(3)).must_be_nil
end
Expand Down