-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branches - Kelsey #36
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You definitely have a feel for linked lists, but you have a few bugs here. A couple of your methods could also use a refactor for readability and reducing complexity.
Take a look at my comments and let me know if you have questions.
# Time complexity - ? | ||
# Space complexity - ? | ||
# Time complexity - O(1) | ||
# Space complexity - O(1), thanks to the power of linked lists we are not making any new data structures, just one new node. | ||
def add_first(data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
# Time complexity - ? | ||
# Space complexity - ? | ||
# Time complexity - O(n), where `n` = index | ||
# Space complexity - O(1) | ||
def get_at_index(index) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about if the index is greater than the length of the list?
def get_last | ||
|
||
if @head.next |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if head
is nil
?
if @head.next | |
return nil if @head.nil? | |
if @head.next |
# Time complexity - ? | ||
# Space complexity - ? | ||
# Time complexity - O(n) | ||
# Space complexity - O(1) | ||
def add_last(data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 This works, but it could be simplified a bit.
# Time complexity - ? | ||
# Space complexity - ? | ||
# Time complexity - O(n), where n is the length of the list | ||
# Space complexity - O(1) | ||
def length |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 This works, but could be simplified a bit.
# Time complexity - ? | ||
# Space complexity - ? | ||
# Time complexity - O(1) | ||
# Space complexity - O(1) | ||
def get_first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Linked List Comprehension Questions