Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#38 Initial implementation of RtRemote #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

carlosmiranda
Copy link
Contributor

#38: Added RtRemote, and incomplete implementation of push. Added puzzles for completing the task.

@codecov-io
Copy link

Codecov Report

Merging #69 into master will decrease coverage by 0.42%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #69      +/-   ##
============================================
- Coverage     93.03%   92.61%   -0.43%     
- Complexity       49       53       +4     
============================================
  Files            11       12       +1     
  Lines           158      176      +18     
  Branches         10       10              
============================================
+ Hits            147      163      +16     
- Misses           11       13       +2
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/zold/api/RtRemote.java 88.88% <88.88%> (ø) 4 <4> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50f250c...7010a28. Read the comment docs.

@0crat 0crat added the scope label Aug 9, 2018
@0crat
Copy link
Collaborator

0crat commented Aug 9, 2018

Job #69 is now in scope, role is REV

@0crat
Copy link
Collaborator

0crat commented Aug 9, 2018

This pull request #69 is assigned to @carlosmiranda/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @llorllale/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job

@carlosmiranda
Copy link
Contributor Author

@llorllale this is my PR, I can't be assigned to it...

@carlosmiranda
Copy link
Contributor Author

@0crat refuse (it's my own PR)

@0crat
Copy link
Collaborator

0crat commented Aug 9, 2018

@0crat refuse (it's my own PR) (here)

@carlosmiranda The user @carlosmiranda/z resigned from #69, please stop working. Reason for job resignation: Order was cancelled

@0crat
Copy link
Collaborator

0crat commented Aug 9, 2018

Tasks refusal is discouraged, see §6: -15 point(s) just awarded to @carlosmiranda/z

@carlosmiranda
Copy link
Contributor Author

@llorllale are there no reviewers? this is a long-running task already

@carlosmiranda
Copy link
Contributor Author

@llorllale this is more than a week old now. Can you assign a REV manually or perhaps take a look yourself?

@llorllale
Copy link
Collaborator

@carlosmiranda we're having funding issues at the moment - let me try to fix

@carlosmiranda
Copy link
Contributor Author

@llorllale any update on the funding situation?

@llorllale
Copy link
Collaborator

@carlosmiranda no updates yet, sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants