Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: broken link #1097

Merged
merged 2 commits into from
May 1, 2024
Merged

fix: broken link #1097

merged 2 commits into from
May 1, 2024

Conversation

ezhil56x
Copy link
Contributor

/claim #1064
Closes #1064

@ezhil56x ezhil56x requested a review from a team as a code owner April 25, 2024 17:15
@algora-pbc algora-pbc bot mentioned this pull request Apr 25, 2024
Closed
@ezhil56x
Copy link
Contributor Author

@jdegoes
This issue is similar to zio/zio-schema/644
Can I get a review on zio/zio-schema/660 as well?
Thanks!

@fsvehla
Copy link
Contributor

fsvehla commented Apr 26, 2024 

[error] java.lang.RuntimeException: The README.md file is not up-to-date!
[error] Please run `sbt docs/generateReadme` and commit new changes.
[error] 	at scala.sys.package$.error(package.scala:30)

@ezhil56x
Copy link
Contributor Author

ezhil56x commented Apr 26, 2024 •
edited
Loading 

[error] java.lang.RuntimeException: The README.md file is not up-to-date!
[error] Please run `sbt docs/generateReadme` and commit new changes.
[error] 	at scala.sys.package$.error(package.scala:30)

@fsvehla
zio/zio-schema#644
In the above PR, it was suggested to remove sbt docs/generateReadme from CI. So I have removed it.

@fsvehla fsvehla merged commit 61b7634 into zio:series/2.x May 1, 2024
27 of 28 checks passed
guizmaii
guizmaii reviewed May 2, 2024
View reviewed changes
.github/workflows/site.yml
@@ -75,8 +75,6 @@ jobs:
distribution: temurin
java-version: 17
check-latest: true
- name: Generate Readme
run: sbt docs/generateReadme
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure that was a good idea to remove that from the CI 🤔

ThijsBroersen pushed a commit to ThijsBroersen/zio-json that referenced this pull request Jun 13, 2024
@ezhil56x @ThijsBroersen
fix: broken link (zio#1097)
4535925 
* fix: broken link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guizmaii guizmaii guizmaii left review comments

Assignees
No one assigned
Labels
🙋 Bounty claim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contributor's Guide page not found
3 participants
@ezhil56x @fsvehla @guizmaii