Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add innr SP-242 plug quirk #3611

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

mgjbroadbent
Copy link

Proposed change

Quirk for the inner SP-242 plug that updates the MeteringCluster to use the existing MeteringClusterInnr. This adds a divisor for the summed energy usage to report correct usage.

Additional information

Tested in HA as a custom quirk against an SP-242.

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

This matches the SP-240 to report the summed energy usage correctly.
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.87%. Comparing base (979551d) to head (88a3ed8).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3611      +/-   ##
==========================================
+ Coverage   89.85%   89.87%   +0.01%     
==========================================
  Files         321      322       +1     
  Lines       10374    10387      +13     
==========================================
+ Hits         9322     9335      +13     
  Misses       1052     1052              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES added the v2 quirk candidate This PR is a good fit to be converted to a v2 quirk. label Dec 13, 2024
@TheJulianJES TheJulianJES added the needs reviewer answer An answer from a reviewer is needed (e.g. why a PR isn't acceptable in the current state). label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs reviewer answer An answer from a reviewer is needed (e.g. why a PR isn't acceptable in the current state). v2 quirk candidate This PR is a good fit to be converted to a v2 quirk.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants