Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements Saswell TRV quirk and tests (Tuya device) #3468

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

Elyasin
Copy link
Contributor

@Elyasin Elyasin commented Oct 27, 2024

Proposed change

Implements Saswell TRV quirk and tests (Tuya device)

Additional information

This is an implementation of the quirk that I believe many use, but it has not been made a PR for this yet.
The device variants are Saswell_TZE200 and Saswell_TYST11. Tests are written and I use it since months in my setup with Home Assistant.

A screen shot of such a TRV device variant:
You can see:

  • anti freeze (hidden; on)
  • away mode (hidden: off)
  • thermostat
  • limescale protection (hidden; on)
  • child lock (hidden; on)
  • temperature calibration
  • window open detection (deactivated)
  • schedule mode (deactivated)

Bildschirmfoto 2024-10-27 um 20 16 42

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

- moves code from file ts0601_trv_sas.py to ts0601_trv.py
- write tests for reading/setting attributes
Copy link

codecov bot commented Oct 27, 2024

Codecov Report

Attention: Patch coverage is 89.80583% with 21 lines in your changes missing coverage. Please review.

Project coverage is 90.20%. Comparing base (56001dd) to head (e98f420).

Files with missing lines Patch % Lines
zhaquirks/tuya/ts0601_trv.py 89.80% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3468      +/-   ##
==========================================
+ Coverage   89.84%   90.20%   +0.35%     
==========================================
  Files         322      321       -1     
  Lines       10371    10476     +105     
==========================================
+ Hits         9318     9450     +132     
+ Misses       1053     1026      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES added the Tuya Request/PR regarding a Tuya device label Oct 27, 2024
@TheJulianJES TheJulianJES added the needs reviewer answer An answer from a reviewer is needed (e.g. why a PR isn't acceptable in the current state). label Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs reviewer answer An answer from a reviewer is needed (e.g. why a PR isn't acceptable in the current state). Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants