-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zlinky_TIC conversion to quirk v2 #3456
base: dev
Are you sure you want to change the base?
Conversation
ef80cf2
to
bd50022
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3456 +/- ##
=======================================
Coverage 89.67% 89.67%
=======================================
Files 316 316
Lines 10281 10287 +6
=======================================
+ Hits 9219 9225 +6
Misses 1062 1062 ☔ View full report in Codecov by Sentry. |
This is ready to review. @TheJulianJES, some of the attributes added in the latest iterations are not automatically updating. Specifically, I'm thinking about "Max Power Phase 2". From what I could figure out from code analysis, the polling the polling interval for those attributes should be added in ZHA itself, for the first phase I could find:
Which does not exist for the other 2phases attributes. If I can change it in the quick, please let me know. Otherwise, I'll open a separate PR in ZHA. |
Update on my previous test :
Looking at your quirk I managed to add the Relay status as well withe the code below. This has the same update problem though:
and
|
Added to PR |
Proposed change
The quirk for is converted to v2 and adds more sensor to the use in HA
Additional information
Checklist
pre-commit
checks pass / the code has been formatted using Black