fix apache#2758, findMappedServices panic

zhangcunli · Dec 23, 2024 · 4f68e26 · 4f68e26
1 parent ea32b5d
commit 4f68e26
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/registry/servicediscovery/service_discovery_registry.go b/registry/servicediscovery/service_discovery_registry.go
@@ -346,16 +346,21 @@ func (s *serviceDiscoveryRegistry) findMappedServices(url *common.URL, listener
 	}
 	if listener != nil {
 		protocolServiceKey := url.ServiceKey() + ":" + url.Protocol
+		s.lock.Lock()
 		s.serviceMappingListeners[protocolServiceKey] = listener
+		s.lock.Unlock()
 	}
 	return serviceNames
 }
 
 func (s *serviceDiscoveryRegistry) stopListen(url *common.URL) {
 	protocolServiceKey := url.ServiceKey() + ":" + url.Protocol
+	s.lock.Lock()
 	listener := s.serviceMappingListeners[protocolServiceKey]
 	if listener != nil {
 		delete(s.serviceMappingListeners, protocolServiceKey)
 		listener.Stop()
 	}
+	s.lock.Unlock()
 }
+