Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clang tidy fail on warning #224

Merged
merged 10 commits into from
Dec 11, 2024
Merged

Clang tidy fail on warning #224

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2dadbfc
fail on error
externl Dec 6, 2024
955936b
clang-tidy 19
externl Dec 6, 2024
ead5454
clang-tidy 20
externl Dec 6, 2024
5a4484c
Merge remote-tracking branch 'origin/main' into clang-tidy
externl Dec 6, 2024
77d7db6
Merge remote-tracking branch 'origin/main' into clang-tidy
externl Dec 10, 2024
f3de845
reformat CheckOptions
externl Dec 10, 2024
9b2d747
clang tidy 19
externl Dec 10, 2024
0e9a9f5
fix
externl Dec 10, 2024
6339142
try ::
externl Dec 10, 2024
757e58e
testing
externl Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .clang-tidy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Checks:
performance-*,
-performance-avoid-endl
'
WarningsAsErrors: ''
WarningsAsErrors: '*'
HeaderFilterRegex: ''
UseColor: true
FormatStyle: 'file'
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/clang_tidy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ jobs:
# This LLVM script will add the relevant LLVM PPA: https://apt.llvm.org/
wget https://apt.llvm.org/llvm.sh -O /tmp/llvm.sh
chmod +x /tmp/llvm.sh
sudo /tmp/llvm.sh 18
sudo apt-get install -y clang-tidy-18
sudo /tmp/llvm.sh 20
sudo apt-get install -y clang-tidy-20
rm /tmp/llvm.sh
clang-tidy-18 --version
clang-tidy-20 --version

- name: Install bear
run: |
Expand Down Expand Up @@ -62,4 +62,4 @@ jobs:
- name: Run Clang Tidy
working-directory: ice-demos/cpp
run: |
find . -name "*.h" -o -name "*.cpp" | xargs run-clang-tidy-18 -j$(nproc) -quiet
run-clang-tidy-20 -j$(nproc) -quiet
Loading