Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] Bltzz solution incl. Unit tests and style checks #250

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

Bltzz
Copy link
Member

@Bltzz Bltzz commented Feb 25, 2024

  • [ADD] all functionality
  • [ADD] Unit tests for all functions + enhance Unit tests with many negative scenarios
  • [ADD] code style checking with lint: npm run lint [-- --fix]

To include lint, just do npm install and add this to the package.json:

// ...
 "scripts": {
    "lint": "eslint **/Bltzz_*.js",
    "test": "mocha || true"
  },
// ...
"devDependencies": {
    // ...
    "eslint": "^8.56.0",
    "eslint-config-airbnb-base": "^11.2.0",
    "eslint-plugin-import": "^2.8.0",
// ...

Warning:

There are some node warnings when executing npm install. They can be fixed with npm audit fix, but should be updated, anyway.

I saw it for this dependency:

get-func-name-2.0.0

Secure Version:

get-func-name-2.0.2

Bltzz added 15 commits February 13, 2024 20:31
- identity
- addb
- subb
- mulb

[ADD] tests + advanced testing for type errors
- mulb,
- minb,
- maxb,
- add,
- sub,
- mul,
- min,
- max,
- addRecurse,
- mulRecurse,
- minRecurse,
- maxRecurse,
- not,
- acc,
- accPartial,
- accRecurse
update sinon-chai dependency + version
- [ADD] func + test for: fill,
- [ADD] func + test for: fillRecurse,
- [ADD] func + test for: set,
- [ADD] func + test for: identityf,
- [ADD] func + test for: addf,
- [ADD] func + test for: liftf,
- [ADD] func + test for: pure
- [ADD] func + test for: curryb,
- [ADD] func + test for: curry,
- [ADD] func + test for: inc,
- [ADD] func + test for: twiceUnary,
- [ADD] func + test for: doubl
- [ADD] func + test for: square,
- [ADD] func + test for: twice,
- [ADD] func + test for: reverseb,
- [ADD] func + test for: reverse,
- [ADD] func + test for: composeuTwo,
- [ADD] func + test for: composeu,
- [ADD] func + test for: composeb
include eslint with airbnb code style to my js

- [STYLE] The current state of the code
- [ADD] func + test for: composeTwo,
- [ADD] func + test for: compose,
- [ADD] func + test for: limitb,
- [ADD] func + test for: limit,
- [ADD] func + test for: genFrom,
- [ADD] func + test for: genTo,
- [ADD] func + test for: genFromTo,
- [ADD] func + test for: elementGen,
- [ADD] func + test for: element,
- [ADD] func + test for: collect,
- [ADD] func + test for: filter,
- [ADD] func + test for: filterTail,
- [ADD] func + test for: concatTwo,
- [ADD] func + test for: concat,
- [ADD] func + test for: concatTail,
- [ADD] func + test for: gensymf,
- [ADD] func + test for: gensymff,
- [ADD] func + test for: fibonaccif,
- [ADD] func + test for: counter,
- [ADD] func + test for: revocableb,
- [ADD] func + test for: revocable,
- [ADD] func + test for: extract,
- [ADD] func + test for: m,
- [ADD] func + test for: addmTwo,
- [ADD] func + test for: addm,
- [ADD] func + test for: liftmbM,
- [ADD] func + test for: liftmb,
- [ADD] func + test for: liftm,
- [ADD] func + test for: exp,
- [ADD] func + test for: expn
- [ADD] func + test for: addg,
- [ADD] func + test for: liftg,
- [ADD] func + test for: arrayg,
- [ADD] func + test for: continuizeu,
- [ADD] func + test for: continuize,
- [ADD] func + test for: vector,
- [ADD] func + test for: exploitVector,
- [ADD] func + test for: vectorSafe,
- [ADD] func + test for: pubsub,
- [ADD] func + test for: mapRecurse,
- [ADD] func + test for: filterRecurse,
- [FIX] Lint error on # sign by adding parserOption `ecmaVersion: 13`
Copy link

🙏 Thanks for your pull request @Bltzz, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
250 2446 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
3 690 557

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant