-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] Bltzz solution incl. Unit tests and style checks #250
Open
Bltzz
wants to merge
15
commits into
zero-to-mastery:master
Choose a base branch
from
Bltzz:BltzzSolution
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- identity - addb - subb - mulb [ADD] tests + advanced testing for type errors
- mulb, - minb, - maxb, - add, - sub, - mul, - min, - max, - addRecurse, - mulRecurse, - minRecurse, - maxRecurse, - not, - acc, - accPartial, - accRecurse
update sinon-chai dependency + version
- [ADD] func + test for: fill, - [ADD] func + test for: fillRecurse, - [ADD] func + test for: set, - [ADD] func + test for: identityf, - [ADD] func + test for: addf, - [ADD] func + test for: liftf, - [ADD] func + test for: pure
- [ADD] func + test for: curryb, - [ADD] func + test for: curry, - [ADD] func + test for: inc, - [ADD] func + test for: twiceUnary, - [ADD] func + test for: doubl
- [ADD] func + test for: square, - [ADD] func + test for: twice, - [ADD] func + test for: reverseb, - [ADD] func + test for: reverse, - [ADD] func + test for: composeuTwo, - [ADD] func + test for: composeu, - [ADD] func + test for: composeb
include eslint with airbnb code style to my js - [STYLE] The current state of the code
- [ADD] func + test for: composeTwo, - [ADD] func + test for: compose, - [ADD] func + test for: limitb, - [ADD] func + test for: limit, - [ADD] func + test for: genFrom, - [ADD] func + test for: genTo, - [ADD] func + test for: genFromTo, - [ADD] func + test for: elementGen, - [ADD] func + test for: element, - [ADD] func + test for: collect,
- [ADD] func + test for: filter, - [ADD] func + test for: filterTail, - [ADD] func + test for: concatTwo, - [ADD] func + test for: concat,
- [ADD] func + test for: concatTail, - [ADD] func + test for: gensymf, - [ADD] func + test for: gensymff, - [ADD] func + test for: fibonaccif, - [ADD] func + test for: counter, - [ADD] func + test for: revocableb, - [ADD] func + test for: revocable, - [ADD] func + test for: extract, - [ADD] func + test for: m, - [ADD] func + test for: addmTwo, - [ADD] func + test for: addm, - [ADD] func + test for: liftmbM, - [ADD] func + test for: liftmb, - [ADD] func + test for: liftm, - [ADD] func + test for: exp, - [ADD] func + test for: expn
- [ADD] func + test for: addg, - [ADD] func + test for: liftg, - [ADD] func + test for: arrayg, - [ADD] func + test for: continuizeu, - [ADD] func + test for: continuize, - [ADD] func + test for: vector, - [ADD] func + test for: exploitVector, - [ADD] func + test for: vectorSafe, - [ADD] func + test for: pubsub, - [ADD] func + test for: mapRecurse, - [ADD] func + test for: filterRecurse, - [FIX] Lint error on # sign by adding parserOption `ecmaVersion: 13`
🙏 Thanks for your pull request @Bltzz, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run lint [-- --fix]
To include lint, just do npm install and add this to the package.json:
Warning:
There are some node warnings when executing
npm install
. They can be fixed withnpm audit fix
, but should be updated, anyway.I saw it for this dependency:
get-func-name-2.0.0
Secure Version:
get-func-name-2.0.2