-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add possibility for XBARB #442
base: master
Are you sure you want to change the base?
Conversation
Thanks for reviewing and approval! Now we just need one more with the right to merge it... Literally one click away! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lam-borg, please ensure your commit messages are signed. While this is the NXP HAL, we follow the Zephyr contribution guidelines.
Also, you have two commits in this PR for a oneline change so clean up the commits.
@dleach02 Thanks for your input; I fixed it accordingly.
|
@lam-borg just realized that we need a Zephyr side manifest PR to point to this |
I made a pull request in zephyr as well: zephyrproject-rtos/zephyr#80225 Anything that i need to add there or here? |
Yes, you need to update the west manifest in that PR to point to this HAL PR. Some documentation is available here: https://docs.zephyrproject.org/latest/develop/modules.html#process-for-submitting-changes-to-existing-modules |
I wasn't aware, its an issue if my PR is behind main. But makes perfect sense, knowing its used for unit tests in the zephyr PR. Now updated. |
include the xbarb driver if configured Signed-off-by: Mathias Landolt <[email protected]>
Somehow, my zephyr PR is waiting on this PR. Did I miss anything? What can I do to get it through? |
So the process we follow for HAL PRs is the following:
Since we are now in the 4.0 feature freeze this process will be delayed until after the 4.0 release, but those are the steps we will follow to get this merged. |
@danieldegrasse ok, thanks for approval and the clarification! |
@dleach02 I think your requested changes have been completed. Can you have a look at this again? |
yes, we need to now coordinate the merge with you zephyr side PR |
We are using the xbarb and it would be nice to have this possibility in the upstream repo aswell.
Thanks for considering