Support default human readable URLs #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying just-be-dev with
|
| Latest commit: |
ccd91e4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d6b63fb0.just-be-dev.pages.dev |
| Branch Preview URL: | https://canonical-urls.just-be-dev.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My site is just a collection of markdown files with ULID filenames. Multiple top level URLs can point to a ULID file, but I only want one canonical URL. The other urls should just redirect to that canonical.
This PR introduces a mapping where URLs are normalized to the ULID via a KV look up and then converted to the canonical URL via another KV lookup. I'm sensitive of the fact that there are now two requests on the render path so I introduced some caching mechanisms for the lookups themselves. Longer term I'll tweak the caching from the CDN side just to invoke the worker less often so it shouldn't be as big of a concern.