Skip to content

WIP

WIP #4058

Triggered via push December 13, 2024 23:56
Status Failure
Total duration 3m 38s
Artifacts

ci.yml

on: push
Matrix: build
Matrix: test-32-bit
Matrix: test
Fit to window
Zoom out
Zoom in

Annotations

84 errors and 194 warnings
field `0` of struct `halo2_poseidon::Squeezing` is private: halo2_gadgets/src/poseidon.rs#L217
error[E0616]: field `0` of struct `halo2_poseidon::Squeezing` is private --> halo2_gadgets/src/poseidon.rs:217:36 | 217 | for entry in self.mode.0.iter_mut() { | ^ private field
field `0` of struct `halo2_poseidon::Absorbing` is private: halo2_gadgets/src/poseidon.rs#L163
error[E0616]: field `0` of struct `halo2_poseidon::Absorbing` is private --> halo2_gadgets/src/poseidon.rs:163:32 | 163 | for entry in self.mode.0.iter_mut() { | ^ private field
field `input` of struct `halo2_poseidon::test_vectors::HashTestVector` is private: halo2_gadgets/src/poseidon/pow5.rs#L874
error[E0616]: field `input` of struct `halo2_poseidon::test_vectors::HashTestVector` is private --> halo2_gadgets/src/poseidon/pow5.rs:874:44 | 874 | pallas::Base::from_repr(tv.input[1]).unwrap(), | ^^^^^ private field
field `input` of struct `halo2_poseidon::test_vectors::HashTestVector` is private: halo2_gadgets/src/poseidon/pow5.rs#L873
error[E0616]: field `input` of struct `halo2_poseidon::test_vectors::HashTestVector` is private --> halo2_gadgets/src/poseidon/pow5.rs:873:44 | 873 | pallas::Base::from_repr(tv.input[0]).unwrap(), | ^^^^^ private field
the trait bound `[poseidon::pow5::StateWord<F>; RATE]: std::convert::TryFrom<&[poseidon::pow5::StateWord<F>]>` is not satisfied: halo2_gadgets/src/poseidon/pow5.rs#L397
error[E0277]: the trait bound `[poseidon::pow5::StateWord<F>; RATE]: std::convert::TryFrom<&[poseidon::pow5::StateWord<F>]>` is not satisfied --> halo2_gadgets/src/poseidon/pow5.rs:397:44 | 397 | Squeezing::init_with(state[..RATE].try_into().unwrap()) | ^^^^^^^^ the trait `std::convert::TryFrom<&[poseidon::pow5::StateWord<F>]>` is not implemented for `[poseidon::pow5::StateWord<F>; RATE]` | = help: the following other types implement trait `std::convert::TryFrom<T>`: `&[T; N]` implements `std::convert::TryFrom<&[T]>` `&mut [T; N]` implements `std::convert::TryFrom<&mut [T]>` `[T; N]` implements `std::convert::TryFrom<&[T]>` `[T; N]` implements `std::convert::TryFrom<&mut [T]>` `[T; N]` implements `std::convert::TryFrom<std::vec::Vec<T, A>>` = note: required for `&[poseidon::pow5::StateWord<F>]` to implement `std::convert::TryInto<[poseidon::pow5::StateWord<F>; RATE]>`
`match` arms have incompatible types: halo2_gadgets/src/poseidon/pow5.rs#L355
error[E0308]: `match` arms have incompatible types --> halo2_gadgets/src/poseidon/pow5.rs:355:29 | 274 | F: Field, | - expected this type parameter ... 344 | let (cell, value) = match input.get(i).expect("i in range").clone() { | _________________________________________- 345 | | Some(PaddedWord::Message(word)) => (word.cell(), word.value().copied()), | | ------------------------------------ this is found to be of type `(halo2_proofs::circuit::Cell, halo2_proofs::circuit::Value<F>)` 346 | | Some(PaddedWord::Padding(padding_value)) => { 347 | | let cell = region ... | 355 | | (cell, Value::known(padding_value)) | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `(Cell, Value<F>)`, found `(Cell, Value<&F>)` 356 | | } 357 | | _ => panic!("Input is not padded"), 358 | | }; | |_____________________- `match` arms have incompatible types | = note: expected tuple `(halo2_proofs::circuit::Cell, halo2_proofs::circuit::Value<_>)` found tuple `(halo2_proofs::circuit::Cell, halo2_proofs::circuit::Value<&_>)`
the trait bound `for<'vr> halo2_proofs::plonk::Assigned<F>: std::convert::From<&'vr &F>` is not satisfied: halo2_gadgets/src/poseidon/pow5.rs#L348
error[E0277]: the trait bound `for<'vr> halo2_proofs::plonk::Assigned<F>: std::convert::From<&'vr &F>` is not satisfied --> halo2_gadgets/src/poseidon/pow5.rs:348:34 | 348 | ... .assign_fixed( | ^^^^^^^^^^^^ the trait `for<'vr> std::convert::From<&'vr &F>` is not implemented for `halo2_proofs::plonk::Assigned<F>` | = help: the following other types implement trait `std::convert::From<T>`: `halo2_proofs::plonk::Assigned<F>` implements `std::convert::From<(F, F)>` `halo2_proofs::plonk::Assigned<F>` implements `std::convert::From<F>` note: required by a bound in `halo2_proofs::circuit::Region::<'r, F>::assign_fixed` --> /home/runner/work/halo2/halo2/halo2_proofs/src/circuit.rs:328:31 | 319 | pub fn assign_fixed<'v, V, VR, A, AR>( | ------------ required by a bound in this associated function ... 328 | for<'vr> Assigned<F>: From<&'vr VR>, | ^^^^^^^^^^^^^ required by this bound in `Region::<'r, F>::assign_fixed`
field `0` of struct `halo2_poseidon::Squeezing` is private: halo2_gadgets/src/poseidon.rs#L217
error[E0616]: field `0` of struct `halo2_poseidon::Squeezing` is private --> halo2_gadgets/src/poseidon.rs:217:36 | 217 | for entry in self.mode.0.iter_mut() { | ^ private field
field `0` of struct `halo2_poseidon::Absorbing` is private: halo2_gadgets/src/poseidon.rs#L163
error[E0616]: field `0` of struct `halo2_poseidon::Absorbing` is private --> halo2_gadgets/src/poseidon.rs:163:32 | 163 | for entry in self.mode.0.iter_mut() { | ^ private field
the trait bound `[poseidon::pow5::StateWord<F>; RATE]: std::convert::TryFrom<&[poseidon::pow5::StateWord<F>]>` is not satisfied: halo2_gadgets/src/poseidon/pow5.rs#L397
error[E0277]: the trait bound `[poseidon::pow5::StateWord<F>; RATE]: std::convert::TryFrom<&[poseidon::pow5::StateWord<F>]>` is not satisfied --> halo2_gadgets/src/poseidon/pow5.rs:397:44 | 397 | Squeezing::init_with(state[..RATE].try_into().unwrap()) | ^^^^^^^^ the trait `std::convert::TryFrom<&[poseidon::pow5::StateWord<F>]>` is not implemented for `[poseidon::pow5::StateWord<F>; RATE]` | = help: the following other types implement trait `std::convert::TryFrom<T>`: `&[T; N]` implements `std::convert::TryFrom<&[T]>` `&mut [T; N]` implements `std::convert::TryFrom<&mut [T]>` `[T; N]` implements `std::convert::TryFrom<&[T]>` `[T; N]` implements `std::convert::TryFrom<&mut [T]>` `[T; N]` implements `std::convert::TryFrom<std::vec::Vec<T, A>>` = note: required for `&[poseidon::pow5::StateWord<F>]` to implement `std::convert::TryInto<[poseidon::pow5::StateWord<F>; RATE]>`
`match` arms have incompatible types: halo2_gadgets/src/poseidon/pow5.rs#L355
error[E0308]: `match` arms have incompatible types --> halo2_gadgets/src/poseidon/pow5.rs:355:29 | 274 | F: Field, | - expected this type parameter ... 344 | let (cell, value) = match input.get(i).expect("i in range").clone() { | _________________________________________- 345 | | Some(PaddedWord::Message(word)) => (word.cell(), word.value().copied()), | | ------------------------------------ this is found to be of type `(halo2_proofs::circuit::Cell, halo2_proofs::circuit::Value<F>)` 346 | | Some(PaddedWord::Padding(padding_value)) => { 347 | | let cell = region ... | 355 | | (cell, Value::known(padding_value)) | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `(Cell, Value<F>)`, found `(Cell, Value<&F>)` 356 | | } 357 | | _ => panic!("Input is not padded"), 358 | | }; | |_____________________- `match` arms have incompatible types | = note: expected tuple `(halo2_proofs::circuit::Cell, halo2_proofs::circuit::Value<_>)` found tuple `(halo2_proofs::circuit::Cell, halo2_proofs::circuit::Value<&_>)`
the trait bound `for<'vr> halo2_proofs::plonk::Assigned<F>: std::convert::From<&'vr &F>` is not satisfied: halo2_gadgets/src/poseidon/pow5.rs#L348
error[E0277]: the trait bound `for<'vr> halo2_proofs::plonk::Assigned<F>: std::convert::From<&'vr &F>` is not satisfied --> halo2_gadgets/src/poseidon/pow5.rs:348:34 | 348 | ... .assign_fixed( | ^^^^^^^^^^^^ the trait `for<'vr> std::convert::From<&'vr &F>` is not implemented for `halo2_proofs::plonk::Assigned<F>` | = help: the following other types implement trait `std::convert::From<T>`: `halo2_proofs::plonk::Assigned<F>` implements `std::convert::From<(F, F)>` `halo2_proofs::plonk::Assigned<F>` implements `std::convert::From<F>` note: required by a bound in `halo2_proofs::circuit::Region::<'r, F>::assign_fixed` --> /home/runner/work/halo2/halo2/halo2_proofs/src/circuit.rs:328:31 | 319 | pub fn assign_fixed<'v, V, VR, A, AR>( | ------------ required by a bound in this associated function ... 328 | for<'vr> Assigned<F>: From<&'vr VR>, | ^^^^^^^^^^^^^ required by this bound in `Region::<'r, F>::assign_fixed`
module `fp` is private: halo2_gadgets/src/poseidon/pow5.rs#L871
error[E0603]: module `fp` is private --> halo2_gadgets/src/poseidon/pow5.rs:871:62 | 871 | for tv in crate::poseidon::primitives::test_vectors::fp::hash() { | ^^ ---- function `hash` is not publicly re-exported | | | private module | note: the module `fp` is defined here --> /home/runner/work/halo2/halo2/halo2_poseidon/src/test_vectors.rs:13:1 | 13 | pub(crate) mod fp { | ^^^^^^^^^^^^^^^^^
function `permute` is private: halo2_gadgets/src/poseidon/pow5.rs#L683
error[E0603]: function `permute` is private --> halo2_gadgets/src/poseidon/pow5.rs:683:23 | 683 | poseidon::permute::<_, S, WIDTH, RATE>( | ^^^^^^^ private function | note: the function `permute` is defined here --> /home/runner/work/halo2/halo2/halo2_poseidon/src/lib.rs:87:1 | 87 | / pub(crate) fn permute<F: Field, S: Spec<F, T, RATE>, const T: usize, const RATE: usize>( 88 | | state: &mut State<F, T>, 89 | | mds: &Mds<F, T>, 90 | | round_constants: &[[F; T]], 91 | | ) { | |_^
Bitrot check: halo2_gadgets/src/poseidon/pow5.rs#L348
the trait bound `for<'vr> Assigned<F>: From<&'vr &F>` is not satisfied
Bitrot check: halo2_gadgets/src/poseidon/pow5.rs#L355
`match` arms have incompatible types
Bitrot check: halo2_gadgets/src/poseidon/pow5.rs#L397
TryFrom<&[pow5::StateWord<F>]>` is not satisfied
Bitrot check: halo2_gadgets/src/poseidon.rs#L163
field `0` of struct `Absorbing` is private
Bitrot check: halo2_gadgets/src/poseidon.rs#L217
field `0` of struct `Squeezing` is private
Bitrot check
The process '/home/runner/.cargo/bin/cargo' failed with exit code 101
Book tests: halo2_gadgets/src/poseidon/pow5.rs#L348
the trait bound `for<'vr> Assigned<F>: From<&'vr &F>` is not satisfied
Book tests: halo2_gadgets/src/poseidon/pow5.rs#L355
`match` arms have incompatible types
Book tests: halo2_gadgets/src/poseidon/pow5.rs#L397
TryFrom<&[StateWord<F>]>` is not satisfied
Book tests: halo2_gadgets/src/poseidon/pow5.rs#L397
TryFrom<&[StateWord<F>]>` is not satisfied
Book tests: halo2_gadgets/src/poseidon.rs#L163
field `0` of struct `Absorbing` is private
Book tests: halo2_gadgets/src/poseidon.rs#L217
field `0` of struct `Squeezing` is private
Book tests
The process '/home/runner/.cargo/bin/cargo' failed with exit code 101
Test on macOS-latest with nightly features
the target feature `neon` is currently unstable
Test on macOS-latest with nightly features
the target feature `neon` is currently unstable
Test on macOS-latest with nightly features
the target feature `neon` is currently unstable
Test on macOS-latest with nightly features
the target feature `neon` is currently unstable
Test on macOS-latest with nightly features
the target feature `neon` is currently unstable
Test on macOS-latest with nightly features
the target feature `neon` is currently unstable
Test on macOS-latest with nightly features
the target feature `neon` is currently unstable
Test on macOS-latest with nightly features
the target feature `neon` is currently unstable
Test on macOS-latest with nightly features
could not compile `aho-corasick` due to 8 previous errors
Test on macOS-latest with nightly features
The process '/Users/runner/.cargo/bin/cargo' failed with exit code 101
Test on windows-latest
The job was canceled because "nightly_macOS-latest" failed.
Test on ubuntu-latest
The job was canceled because "nightly_macOS-latest" failed.
Test on ubuntu-latest
The operation was canceled.
Test on macOS-latest with beta features
The job was canceled because "nightly_macOS-latest" failed.
Test on macOS-latest with beta features
the target feature `neon` is currently unstable
Test on macOS-latest with beta features
the target feature `neon` is currently unstable
Test on macOS-latest with beta features
the target feature `neon` is currently unstable
Test on macOS-latest with beta features
the target feature `neon` is currently unstable
Test on macOS-latest with beta features
the target feature `neon` is currently unstable
Test on macOS-latest with beta features
the target feature `neon` is currently unstable
Test on macOS-latest with beta features
the target feature `neon` is currently unstable
Test on macOS-latest with beta features
the target feature `neon` is currently unstable
Test on macOS-latest with beta features
could not compile `aho-corasick` due to 8 previous errors
Test on macOS-latest with beta features
The process '/Users/runner/.cargo/bin/cargo' failed with exit code 101
Test on ubuntu-latest with beta features
The job was canceled because "nightly_macOS-latest" failed.
Test on ubuntu-latest with beta features
The operation was canceled.
Test on windows-latest with beta features
The job was canceled because "nightly_macOS-latest" failed.
Test on ubuntu-latest with nightly features
The job was canceled because "nightly_macOS-latest" failed.
Test on ubuntu-latest with nightly features
The operation was canceled.
Test on windows-latest with nightly features
The job was canceled because "nightly_macOS-latest" failed.
Test on macOS-latest
The job was canceled because "nightly_macOS-latest" failed.
Test on macOS-latest
The operation was canceled.
Build target wasm32-wasi: halo2_gadgets/src/poseidon/pow5.rs#L348
the trait bound `for<'vr> Assigned<F>: From<&'vr &F>` is not satisfied
Build target wasm32-wasi: halo2_gadgets/src/poseidon/pow5.rs#L355
`match` arms have incompatible types
Build target wasm32-wasi: halo2_gadgets/src/poseidon/pow5.rs#L397
TryFrom<&[pow5::StateWord<F>]>` is not satisfied
Build target wasm32-wasi: halo2_gadgets/src/poseidon/pow5.rs#L397
TryFrom<&[pow5::StateWord<F>]>` is not satisfied
Build target wasm32-wasi: halo2_gadgets/src/poseidon.rs#L163
field `0` of struct `Absorbing` is private
Build target wasm32-wasi: halo2_gadgets/src/poseidon.rs#L217
field `0` of struct `Squeezing` is private
Build target wasm32-wasi
The process '/home/runner/.cargo/bin/cargo' failed with exit code 101
Build target wasm32-unknown-unknown
The job was canceled because "wasm32-wasi" failed.
Build target wasm32-unknown-unknown: halo2_gadgets/src/poseidon/pow5.rs#L348
the trait bound `for<'vr> Assigned<F>: From<&'vr &F>` is not satisfied
Build target wasm32-unknown-unknown
The operation was canceled.
function is never used: `hash`: halo2_poseidon/src/test_vectors.rs#L1045
error: function is never used: `hash` --> halo2_poseidon/src/test_vectors.rs:1045:19 | 1045 | pub(crate) fn hash() -> Vec<HashTestVector> { | ^^^^
function is never used: `permute`: halo2_poseidon/src/test_vectors.rs#L641
error: function is never used: `permute` --> halo2_poseidon/src/test_vectors.rs:641:19 | 641 | pub(crate) fn permute() -> Vec<PermuteTestVector> { | ^^^^^^^
function is never used: `hash`: halo2_poseidon/src/test_vectors.rs#L420
error: function is never used: `hash` --> halo2_poseidon/src/test_vectors.rs:420:19 | 420 | pub(crate) fn hash() -> Vec<HashTestVector> { | ^^^^
function is never used: `permute`: halo2_poseidon/src/test_vectors.rs#L16
error: function is never used: `permute` --> halo2_poseidon/src/test_vectors.rs:16:19 | 16 | pub(crate) fn permute() -> Vec<PermuteTestVector> { | ^^^^^^^
struct is never constructed: `HashTestVector`: halo2_poseidon/src/test_vectors.rs#L8
error: struct is never constructed: `HashTestVector` --> halo2_poseidon/src/test_vectors.rs:8:19 | 8 | pub(crate) struct HashTestVector { | ^^^^^^^^^^^^^^
struct is never constructed: `PermuteTestVector`: halo2_poseidon/src/test_vectors.rs#L3
error: struct is never constructed: `PermuteTestVector` --> halo2_poseidon/src/test_vectors.rs:3:19 | 3 | pub(crate) struct PermuteTestVector { | ^^^^^^^^^^^^^^^^^ | = note: `-D dead-code` implied by `-D warnings`
Code coverage
Broken pipe (os error 32)
Code coverage
could not compile `halo2_gadgets` (lib test) due to 9 previous errors; 1 warning emitted
Code coverage: halo2_gadgets/src/poseidon/pow5.rs#L683
function `permute` is private
Code coverage
The process '/home/runner/.cargo/bin/cargo' failed with exit code 1
Test on i686-unknown-linux-gnu with nightly features
Process completed with exit code 101.
Test on i686-unknown-linux-gnu with beta features
The job was canceled because "nightly" failed.
Test on i686-unknown-linux-gnu with beta features
Process completed with exit code 101.
Test on i686-unknown-linux-gnu
The job was canceled because "nightly" failed.
Test on i686-unknown-linux-gnu
The operation was canceled.
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
usage of `Iterator::fold` on a type that implements `Try`: halo2_proofs/src/dev.rs#L1066
warning: usage of `Iterator::fold` on a type that implements `Try` --> halo2_proofs/src/dev.rs:1066:30 | 1066 | ... .fold(Ok(()), |acc, res| acc.and(res)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold((), |acc, res| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold = note: `-W clippy::manual-try-fold` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::manual_try_fold)]`
the borrowed expression implements the required traits: halo2_proofs/src/dev.rs#L683
warning: the borrowed expression implements the required traits --> halo2_proofs/src/dev.rs:683:41 | 683 | / ... &util::load_instance( 684 | | ... n, 685 | | ... row, 686 | | ... &self.cs.instance_queries, 687 | | ... &self.instance, 688 | | ... ), | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args help: change this to | 683 ~ util::load_instance( 684 + n, 685 + row, 686 + &self.cs.instance_queries, 687 + &self.instance, 688 ~ ), |
the borrowed expression implements the required traits: halo2_proofs/src/dev.rs#L682
warning: the borrowed expression implements the required traits --> halo2_proofs/src/dev.rs:682:41 | 682 | ... &util::load(n, row, &self.cs.advice_queries, &self.advice), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `util::load(n, row, &self.cs.advice_queries, &self.advice)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: halo2_proofs/src/dev.rs#L681
warning: the borrowed expression implements the required traits --> halo2_proofs/src/dev.rs:681:41 | 681 | ... &util::load(n, row, &self.cs.fixed_queries, &self.fixed), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `util::load(n, row, &self.cs.fixed_queries, &self.fixed)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the following explicit lifetimes could be elided: 'cs: halo2_proofs/src/dev/tfp.rs#L352
warning: the following explicit lifetimes could be elided: 'cs --> halo2_proofs/src/dev/tfp.rs:352:6 | 352 | impl<'cs, F: Field, CS: Assignment<F>> Assignment<F> for TracingAssignment<'cs, F, CS> { | ^^^ ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 352 - impl<'cs, F: Field, CS: Assignment<F>> Assignment<F> for TracingAssignment<'cs, F, CS> { 352 + impl<F: Field, CS: Assignment<F>> Assignment<F> for TracingAssignment<'_, F, CS> { |
the following explicit lifetimes could be elided: 'r: halo2_proofs/src/dev/tfp.rs#L225
warning: the following explicit lifetimes could be elided: 'r --> halo2_proofs/src/dev/tfp.rs:225:6 | 225 | impl<'r, F: Field> RegionLayouter<F> for TracingRegion<'r, F> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 225 - impl<'r, F: Field> RegionLayouter<F> for TracingRegion<'r, F> { 225 + impl<F: Field> RegionLayouter<F> for TracingRegion<'_, F> { |
the following explicit lifetimes could be elided: 'c: halo2_proofs/src/dev/tfp.rs#L121
warning: the following explicit lifetimes could be elided: 'c --> halo2_proofs/src/dev/tfp.rs:121:6 | 121 | impl<'c, F: Field, C: Circuit<F>> Circuit<F> for TracingCircuit<'c, F, C> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 121 - impl<'c, F: Field, C: Circuit<F>> Circuit<F> for TracingCircuit<'c, F, C> { 121 + impl<F: Field, C: Circuit<F>> Circuit<F> for TracingCircuit<'_, F, C> { |
use of `default` to create a unit struct: halo2_proofs/src/dev/cost.rs#L414
warning: use of `default` to create a unit struct --> halo2_proofs/src/dev/cost.rs:414:33 | 414 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: halo2_proofs/src/dev/cost.rs#L371
warning: use of `default` to create a unit struct --> halo2_proofs/src/dev/cost.rs:371:33 | 371 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: halo2_proofs/src/dev/cost.rs#L328
warning: use of `default` to create a unit struct --> halo2_proofs/src/dev/cost.rs:328:33 | 328 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/poly.rs#L174
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/poly.rs:174:22 | 174 | .zip(inv_denoms.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `inv_denoms` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/202008a1b8de96d2e5b6bc02d379db03a877d34d/library/core/src/iter/traits/iterator.rs:589:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
this bound is already specified as the supertrait of `ExactSizeIterator`: halo2_proofs/src/poly.rs#L167
warning: this bound is already specified as the supertrait of `ExactSizeIterator` --> halo2_proofs/src/poly.rs:167:26 | 167 | inv_denoms: impl Iterator<Item = F> + ExactSizeIterator, | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls = note: `-W clippy::implied-bounds-in-impls` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::implied_bounds_in_impls)]` help: try removing this bound | 167 - inv_denoms: impl Iterator<Item = F> + ExactSizeIterator, 167 + inv_denoms: impl ExactSizeIterator<Item = F>, |
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/poly.rs#L159
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/poly.rs:159:14 | 159 | .zip(assigned_denominators.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `assigned_denominators` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/202008a1b8de96d2e5b6bc02d379db03a877d34d/library/core/src/iter/traits/iterator.rs:589:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
the following explicit lifetimes could be elided: 'a: halo2_proofs/src/poly/multiopen/prover.rs#L125
warning: the following explicit lifetimes could be elided: 'a --> halo2_proofs/src/poly/multiopen/prover.rs:125:6 | 125 | impl<'a, C: CurveAffine> PartialEq for PolynomialPointer<'a, C> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 125 - impl<'a, C: CurveAffine> PartialEq for PolynomialPointer<'a, C> { 125 + impl<C: CurveAffine> PartialEq for PolynomialPointer<'_, C> { |
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/poly/multiopen/prover.rs#L105
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/poly/multiopen/prover.rs:105:58 | 105 | let (p_poly, p_poly_blind) = q_polys.into_iter().zip(q_blinds.into_iter()).fold( | ^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `q_blinds` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/202008a1b8de96d2e5b6bc02d379db03a877d34d/library/core/src/iter/traits/iterator.rs:589:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
use of `default` to create a unit struct: halo2_proofs/src/poly/evaluator.rs#L124
warning: use of `default` to create a unit struct --> halo2_proofs/src/poly/evaluator.rs:124:36 | 124 | _evaluator: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: halo2_proofs/src/poly/evaluator.rs#L78
warning: use of `default` to create a unit struct --> halo2_proofs/src/poly/evaluator.rs:78:36 | 78 | _evaluator: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `-W clippy::default-constructed-unit-structs` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::default_constructed_unit_structs)]`
the borrowed expression implements the required traits: halo2_proofs/src/poly/domain.rs#L559
warning: the borrowed expression implements the required traits --> halo2_proofs/src/poly/domain.rs:559:20 | 559 | let xn = x.pow(&[8, 0, 0, 0]); | ^^^^^^^^^^^^^ help: change this to: `[8, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: halo2_proofs/src/poly/domain.rs#L549
warning: the borrowed expression implements the required traits --> halo2_proofs/src/poly/domain.rs:549:38 | 549 | points.push(domain.omega.pow(&[i, 0, 0, 0])); | ^^^^^^^^^^^^^ help: change this to: `[i, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/plonk/verifier.rs#L319
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/verifier.rs:319:25 | 319 | / lookups 320 | | .iter() 321 | | .flat_map(move |p| p.queries(vk, x)) 322 | | .into_iter(), | |________________________________________^ | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/202008a1b8de96d2e5b6bc02d379db03a877d34d/library/core/src/iter/traits/iterator.rs:471:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing the `.into_iter()` | 319 ~ lookups 320 + .iter() 321 ~ .flat_map(move |p| p.queries(vk, x)), |
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/plonk/verifier.rs#L259
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/verifier.rs:259:25 | 259 | / lookups 260 | | .iter() 261 | | .zip(vk.cs.lookups.iter()) 262 | | .flat_map(move |(p, argument)| { ... | 275 | | }) 276 | | .into_iter(), | |________________________________________^ | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/202008a1b8de96d2e5b6bc02d379db03a877d34d/library/core/src/iter/traits/iterator.rs:471:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing the `.into_iter()` | 259 ~ lookups 260 + .iter() 261 + .zip(vk.cs.lookups.iter()) 262 + .flat_map(move |(p, argument)| { 263 + p.expressions( 264 + l_0, 265 + l_last, 266 + l_blind, 267 + argument, 268 + theta, 269 + beta, 270 + gamma, 271 + advice_evals, 272 + fixed_evals, 273 + instance_evals, 274 + ) 275 ~ }), |
the borrowed expression implements the required traits: halo2_proofs/src/plonk/verifier.rs#L206
warning: the borrowed expression implements the required traits --> halo2_proofs/src/plonk/verifier.rs:206:24 | 206 | let xn = x.pow(&[params.n, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[params.n, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/plonk/prover.rs#L707
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/prover.rs:707:24 | 707 | .chain(lookups.iter().flat_map(move |p| p.open(pk, x)).into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `lookups.iter().flat_map(move |p| p.open(pk, x))` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/202008a1b8de96d2e5b6bc02d379db03a877d34d/library/core/src/iter/traits/iterator.rs:471:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
the borrowed expression implements the required traits: halo2_proofs/src/plonk/prover.rs#L599
warning: the borrowed expression implements the required traits --> halo2_proofs/src/plonk/prover.rs:599:20 | 599 | let xn = x.pow(&[params.n, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[params.n, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/plonk/prover.rs#L581
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/prover.rs:581:28 | 581 | .chain(permutation_expressions.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `permutation_expressions` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/202008a1b8de96d2e5b6bc02d379db03a877d34d/library/core/src/iter/traits/iterator.rs:471:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/plonk/prover.rs#L547
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/prover.rs:547:14 | 547 | .zip(lookup_expressions.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `lookup_expressions` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/202008a1b8de96d2e5b6bc02d379db03a877d34d/library/core/src/iter/traits/iterator.rs:589:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/plonk/prover.rs#L546
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/prover.rs:546:14 | 546 | .zip(permutation_expressions.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `permutation_expressions` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/202008a1b8de96d2e5b6bc02d379db03a877d34d/library/core/src/iter/traits/iterator.rs:589:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
the following explicit lifetimes could be elided: 'a: halo2_proofs/src/plonk/prover.rs#L147
warning: the following explicit lifetimes could be elided: 'a --> halo2_proofs/src/plonk/prover.rs:147:18 | 147 | impl<'a, F: Field> Assignment<F> for WitnessCollection<'a, F> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 147 - impl<'a, F: Field> Assignment<F> for WitnessCollection<'a, F> { 147 + impl<F: Field> Assignment<F> for WitnessCollection<'_, F> { |
doc list item without indentation: halo2_proofs/src/plonk/lookup/prover.rs#L562
warning: doc list item without indentation --> halo2_proofs/src/plonk/lookup/prover.rs:562:5 | 562 | /// This method returns (A', S') if no errors are encountered. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 562 | /// This method returns (A', S') if no errors are encountered. | ++
doc list item without indentation: halo2_proofs/src/plonk/lookup/prover.rs#L74
warning: doc list item without indentation --> halo2_proofs/src/plonk/lookup/prover.rs:74:9 | 74 | /// The Permuted<C> struct is used to update the Lookup, and is then returned. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation = note: `-W clippy::doc-lazy-continuation` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::doc_lazy_continuation)]` help: indent this line | 74 | /// The Permuted<C> struct is used to update the Lookup, and is then returned. | ++
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/plonk/circuit.rs#L1261
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/circuit.rs:1261:22 | 1261 | .zip(degrees.into_iter()) | ^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `degrees` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/202008a1b8de96d2e5b6bc02d379db03a877d34d/library/core/src/iter/traits/iterator.rs:589:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
the following explicit lifetimes could be elided: 'a: halo2_proofs/src/plonk/circuit.rs#L988
warning: the following explicit lifetimes could be elided: 'a --> halo2_proofs/src/plonk/circuit.rs:988:6 | 988 | impl<'a, F: Field> std::fmt::Debug for PinnedGates<'a, F> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 988 - impl<'a, F: Field> std::fmt::Debug for PinnedGates<'a, F> { 988 + impl<F: Field> std::fmt::Debug for PinnedGates<'_, F> { |
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/plonk/circuit.rs#L893
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/circuit.rs:893:18 | 893 | .zip(self.constraints.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `self.constraints` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/202008a1b8de96d2e5b6bc02d379db03a877d34d/library/core/src/iter/traits/iterator.rs:589:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-W clippy::useless-conversion` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::useless_conversion)]`
the following explicit lifetimes could be elided: 'r: halo2_proofs/src/circuit.rs#L380
warning: the following explicit lifetimes could be elided: 'r --> halo2_proofs/src/circuit.rs:380:6 | 380 | impl<'r, F: Field> Table<'r, F> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 380 - impl<'r, F: Field> Table<'r, F> { 380 + impl<F: Field> Table<'_, F> { |
the following explicit lifetimes could be elided: 'r: halo2_proofs/src/circuit.rs#L191
warning: the following explicit lifetimes could be elided: 'r --> halo2_proofs/src/circuit.rs:191:6 | 191 | impl<'r, F: Field> Region<'r, F> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 191 - impl<'r, F: Field> Region<'r, F> { 191 + impl<F: Field> Region<'_, F> { |
the following explicit lifetimes could be elided: 'r: halo2_proofs/src/circuit/table_layouter.rs#L67
warning: the following explicit lifetimes could be elided: 'r --> halo2_proofs/src/circuit/table_layouter.rs:67:6 | 67 | impl<'r, 'a, F: Field, CS: Assignment<F> + 'a> TableLayouter<F> | ^^ 68 | for SimpleTableLayouter<'r, 'a, F, CS> | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 67 ~ impl<'a, F: Field, CS: Assignment<F> + 'a> TableLayouter<F> 68 ~ for SimpleTableLayouter<'_, 'a, F, CS> |
the following explicit lifetimes could be elided: 'r: halo2_proofs/src/circuit/table_layouter.rs#L48
warning: the following explicit lifetimes could be elided: 'r --> halo2_proofs/src/circuit/table_layouter.rs:48:6 | 48 | impl<'r, 'a, F: Field, CS: Assignment<F> + 'a> fmt::Debug for SimpleTableLayouter<'r, 'a, F, CS> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 48 - impl<'r, 'a, F: Field, CS: Assignment<F> + 'a> fmt::Debug for SimpleTableLayouter<'r, 'a, F, CS> { 48 + impl<'a, F: Field, CS: Assignment<F> + 'a> fmt::Debug for SimpleTableLayouter<'_, 'a, F, CS> { |
the following explicit lifetimes could be elided: 'r: halo2_proofs/src/circuit/floor_planner/v1.rs#L363
warning: the following explicit lifetimes could be elided: 'r --> halo2_proofs/src/circuit/floor_planner/v1.rs:363:6 | 363 | impl<'r, 'a, F: Field, CS: Assignment<F> + 'a> RegionLayouter<F> for V1Region<'r, 'a, F, CS> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 363 - impl<'r, 'a, F: Field, CS: Assignment<F> + 'a> RegionLayouter<F> for V1Region<'r, 'a, F, CS> { 363 + impl<'a, F: Field, CS: Assignment<F> + 'a> RegionLayouter<F> for V1Region<'_, 'a, F, CS> { |
the following explicit lifetimes could be elided: 'r: halo2_proofs/src/circuit/floor_planner/v1.rs#L348
warning: the following explicit lifetimes could be elided: 'r --> halo2_proofs/src/circuit/floor_planner/v1.rs:348:6 | 348 | impl<'r, 'a, F: Field, CS: Assignment<F> + 'a> fmt::Debug for V1Region<'r, 'a, F, CS> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 348 - impl<'r, 'a, F: Field, CS: Assignment<F> + 'a> fmt::Debug for V1Region<'r, 'a, F, CS> { 348 + impl<'a, F: Field, CS: Assignment<F> + 'a> fmt::Debug for V1Region<'_, 'a, F, CS> { |
the following explicit lifetimes could be elided: 'p: halo2_proofs/src/circuit/floor_planner/v1.rs#L163
warning: the following explicit lifetimes could be elided: 'p --> halo2_proofs/src/circuit/floor_planner/v1.rs:163:6 | 163 | impl<'p, 'a, F: Field, CS: Assignment<F> + 'a> Layouter<F> for V1Pass<'p, 'a, F, CS> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 163 - impl<'p, 'a, F: Field, CS: Assignment<F> + 'a> Layouter<F> for V1Pass<'p, 'a, F, CS> { 163 + impl<'a, F: Field, CS: Assignment<F> + 'a> Layouter<F> for V1Pass<'_, 'a, F, CS> { |
the following explicit lifetimes could be elided: 'r: halo2_proofs/src/circuit/floor_planner/single_pass.rs#L246
warning: the following explicit lifetimes could be elided: 'r --> halo2_proofs/src/circuit/floor_planner/single_pass.rs:246:6 | 246 | impl<'r, 'a, F: Field, CS: Assignment<F> + 'a> RegionLayouter<F> | ^^ 247 | for SingleChipLayouterRegion<'r, 'a, F, CS> | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 246 ~ impl<'a, F: Field, CS: Assignment<F> + 'a> RegionLayouter<F> 247 ~ for SingleChipLayouterRegion<'_, 'a, F, CS> |
the following explicit lifetimes could be elided: 'r: halo2_proofs/src/circuit/floor_planner/single_pass.rs#L225
warning: the following explicit lifetimes could be elided: 'r --> halo2_proofs/src/circuit/floor_planner/single_pass.rs:225:6 | 225 | impl<'r, 'a, F: Field, CS: Assignment<F> + 'a> fmt::Debug | ^^ 226 | for SingleChipLayouterRegion<'r, 'a, F, CS> | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `-W clippy::needless-lifetimes` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_lifetimes)]` help: elide the lifetimes | 225 ~ impl<'a, F: Field, CS: Assignment<F> + 'a> fmt::Debug 226 ~ for SingleChipLayouterRegion<'_, 'a, F, CS> |
struct `PointIndex` is never constructed: halo2_proofs/src/plonk/circuit.rs#L769
warning: struct `PointIndex` is never constructed --> halo2_proofs/src/plonk/circuit.rs:769:19 | 769 | pub(crate) struct PointIndex(pub usize); | ^^^^^^^^^^
trait `IndexedParallelIterator` is never used: halo2_proofs/src/multicore.rs#L28
warning: trait `IndexedParallelIterator` is never used --> halo2_proofs/src/multicore.rs:28:11 | 28 | pub trait IndexedParallelIterator: std::iter::Iterator {} | ^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
unused import: `std::convert::TryInto`: halo2_gadgets/src/poseidon.rs#L3
warning: unused import: `std::convert::TryInto` --> halo2_gadgets/src/poseidon.rs:3:5 | 3 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
use of `default` to create a unit struct: halo2_poseidon/src/lib.rs#L389
warning: use of `default` to create a unit struct --> halo2_poseidon/src/lib.rs:389:33 | 389 | _domain: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: halo2_poseidon/src/lib.rs#L283
warning: use of `default` to create a unit struct --> halo2_poseidon/src/lib.rs:283:33 | 283 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: halo2_poseidon/src/lib.rs#L246
warning: use of `default` to create a unit struct --> halo2_poseidon/src/lib.rs:246:33 | 246 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
called `.iter().nth()` on a slice: halo2_poseidon/src/lib.rs#L199
warning: called `.iter().nth()` on a slice --> halo2_poseidon/src/lib.rs:199:9 | 199 | self.0.iter().nth(n).map(|x| x.as_ref()) | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth = note: `-W clippy::iter-nth` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::iter_nth)]` help: `get` is equivalent but more concise | 199 | self.0.get(n).map(|x| x.as_ref()) | ~~~
use of `default` to create a unit struct: halo2_poseidon/src/p128pow5t3.rs#L86
warning: use of `default` to create a unit struct --> halo2_poseidon/src/p128pow5t3.rs:86:38 | 86 | P128Pow5T3Gen(PhantomData::default()) | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: halo2_poseidon/src/grain.rs#L72
warning: use of `default` to create a unit struct --> halo2_poseidon/src/grain.rs:72:32 | 72 | _field: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `-W clippy::default-constructed-unit-structs` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::default_constructed_unit_structs)]`
unused import: `std::convert::TryInto`: halo2_gadgets/src/poseidon.rs#L3
warning: unused import: `std::convert::TryInto` --> halo2_gadgets/src/poseidon.rs:3:5 | 3 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
struct `Variable` is never constructed: halo2_proofs/tests/plonk_api.rs#L26
warning: struct `Variable` is never constructed --> halo2_proofs/tests/plonk_api.rs:26:16 | 26 | pub struct Variable(Column<Advice>, usize); | ^^^^^^^^ | = note: `Variable` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default
unused doc comment: halo2_proofs/src/dev/cost.rs#L109
warning: unused doc comment --> halo2_proofs/src/dev/cost.rs:109:13 | 109 | /// Selector assignments used for optimization pass | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 110 | selectors: vec![vec![false; n]; num_selectors], | ---------------------------------------------- rustdoc does not generate documentation for expression fields | = help: use `//` for a plain comment
unused doc comment: halo2_proofs/src/dev/cost.rs#L107
warning: unused doc comment --> halo2_proofs/src/dev/cost.rs:107:13 | 107 | /// Pairs of cells between which we have equality constraints. | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 108 | equality: vec![], | ---------------- rustdoc does not generate documentation for expression fields | = help: use `//` for a plain comment
unused doc comment: halo2_proofs/src/dev/cost.rs#L105
warning: unused doc comment --> halo2_proofs/src/dev/cost.rs:105:13 | 105 | /// Any cells assigned outside of a region. | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 106 | loose_cells: vec![], | ------------------- rustdoc does not generate documentation for expression fields | = help: use `//` for a plain comment = note: `#[warn(unused_doc_comments)]` on by default
unused imports: `ParallelIterator` and `Scope`: halo2_proofs/src/multicore.rs#L15
warning: unused imports: `ParallelIterator` and `Scope` --> halo2_proofs/src/multicore.rs:15:34 | 15 | iter::{IntoParallelIterator, ParallelIterator}, | ^^^^^^^^^^^^^^^^ 16 | join, scope, Scope, | ^^^^^ | = note: `#[warn(unused_imports)]` on by default
use of `default` to create a unit struct: halo2_poseidon/src/lib.rs#L389
warning: use of `default` to create a unit struct --> halo2_poseidon/src/lib.rs:389:33 | 389 | _domain: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: halo2_poseidon/src/lib.rs#L283
warning: use of `default` to create a unit struct --> halo2_poseidon/src/lib.rs:283:33 | 283 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: halo2_poseidon/src/lib.rs#L246
warning: use of `default` to create a unit struct --> halo2_poseidon/src/lib.rs:246:33 | 246 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
called `.iter().nth()` on a slice: halo2_poseidon/src/lib.rs#L199
warning: called `.iter().nth()` on a slice --> halo2_poseidon/src/lib.rs:199:9 | 199 | self.0.iter().nth(n).map(|x| x.as_ref()) | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth = note: `-W clippy::iter-nth` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::iter_nth)]` help: `get` is equivalent but more concise | 199 | self.0.get(n).map(|x| x.as_ref()) | ~~~
use of `default` to create a unit struct: halo2_poseidon/src/grain.rs#L72
warning: use of `default` to create a unit struct --> halo2_poseidon/src/grain.rs:72:32 | 72 | _field: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `-W clippy::default-constructed-unit-structs` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::default_constructed_unit_structs)]`
struct `Variable` is never constructed: halo2_proofs/benches/plonk.rs#L19
warning: struct `Variable` is never constructed --> halo2_proofs/benches/plonk.rs:19:16 | 19 | pub struct Variable(Column<Advice>, usize); | ^^^^^^^^ | = note: `Variable` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default
function `hash` is never used: halo2_poseidon/src/test_vectors.rs#L1045
warning: function `hash` is never used --> halo2_poseidon/src/test_vectors.rs:1045:19 | 1045 | pub(crate) fn hash() -> Vec<HashTestVector> { | ^^^^
function `permute` is never used: halo2_poseidon/src/test_vectors.rs#L641
warning: function `permute` is never used --> halo2_poseidon/src/test_vectors.rs:641:19 | 641 | pub(crate) fn permute() -> Vec<PermuteTestVector> { | ^^^^^^^
function `hash` is never used: halo2_poseidon/src/test_vectors.rs#L420
warning: function `hash` is never used --> halo2_poseidon/src/test_vectors.rs:420:19 | 420 | pub(crate) fn hash() -> Vec<HashTestVector> { | ^^^^
function `permute` is never used: halo2_poseidon/src/test_vectors.rs#L16
warning: function `permute` is never used --> halo2_poseidon/src/test_vectors.rs:16:19 | 16 | pub(crate) fn permute() -> Vec<PermuteTestVector> { | ^^^^^^^
struct `HashTestVector` is never constructed: halo2_poseidon/src/test_vectors.rs#L8
warning: struct `HashTestVector` is never constructed --> halo2_poseidon/src/test_vectors.rs:8:19 | 8 | pub(crate) struct HashTestVector { | ^^^^^^^^^^^^^^
struct `PermuteTestVector` is never constructed: halo2_poseidon/src/test_vectors.rs#L3
warning: struct `PermuteTestVector` is never constructed --> halo2_poseidon/src/test_vectors.rs:3:19 | 3 | pub(crate) struct PermuteTestVector { | ^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
the borrowed expression implements the required traits: halo2_proofs/src/dev.rs#L683
warning: the borrowed expression implements the required traits --> halo2_proofs/src/dev.rs:683:41 | 683 | / ... &util::load_instance( 684 | | ... n, 685 | | ... row, 686 | | ... &self.cs.instance_queries, 687 | | ... &self.instance, 688 | | ... ), | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args help: change this to | 683 ~ util::load_instance( 684 + n, 685 + row, 686 + &self.cs.instance_queries, 687 + &self.instance, 688 ~ ), |
the borrowed expression implements the required traits: halo2_proofs/src/dev.rs#L682
warning: the borrowed expression implements the required traits --> halo2_proofs/src/dev.rs:682:41 | 682 | ... &util::load(n, row, &self.cs.advice_queries, &self.advice), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `util::load(n, row, &self.cs.advice_queries, &self.advice)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: halo2_proofs/src/dev.rs#L681
warning: the borrowed expression implements the required traits --> halo2_proofs/src/dev.rs:681:41 | 681 | ... &util::load(n, row, &self.cs.fixed_queries, &self.fixed), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `util::load(n, row, &self.cs.fixed_queries, &self.fixed)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the following explicit lifetimes could be elided: 'cs: halo2_proofs/src/dev/tfp.rs#L352
warning: the following explicit lifetimes could be elided: 'cs --> halo2_proofs/src/dev/tfp.rs:352:6 | 352 | impl<'cs, F: Field, CS: Assignment<F>> Assignment<F> for TracingAssignment<'cs, F, CS> { | ^^^ ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 352 - impl<'cs, F: Field, CS: Assignment<F>> Assignment<F> for TracingAssignment<'cs, F, CS> { 352 + impl<F: Field, CS: Assignment<F>> Assignment<F> for TracingAssignment<'_, F, CS> { |
the following explicit lifetimes could be elided: 'r: halo2_proofs/src/dev/tfp.rs#L225
warning: the following explicit lifetimes could be elided: 'r --> halo2_proofs/src/dev/tfp.rs:225:6 | 225 | impl<'r, F: Field> RegionLayouter<F> for TracingRegion<'r, F> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 225 - impl<'r, F: Field> RegionLayouter<F> for TracingRegion<'r, F> { 225 + impl<F: Field> RegionLayouter<F> for TracingRegion<'_, F> { |
the following explicit lifetimes could be elided: 'c: halo2_proofs/src/dev/tfp.rs#L121
warning: the following explicit lifetimes could be elided: 'c --> halo2_proofs/src/dev/tfp.rs:121:6 | 121 | impl<'c, F: Field, C: Circuit<F>> Circuit<F> for TracingCircuit<'c, F, C> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 121 - impl<'c, F: Field, C: Circuit<F>> Circuit<F> for TracingCircuit<'c, F, C> { 121 + impl<F: Field, C: Circuit<F>> Circuit<F> for TracingCircuit<'_, F, C> { |
use of `default` to create a unit struct: halo2_proofs/src/dev/cost.rs#L414
warning: use of `default` to create a unit struct --> halo2_proofs/src/dev/cost.rs:414:33 | 414 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: halo2_proofs/src/dev/cost.rs#L371
warning: use of `default` to create a unit struct --> halo2_proofs/src/dev/cost.rs:371:33 | 371 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: halo2_proofs/src/dev/cost.rs#L328
warning: use of `default` to create a unit struct --> halo2_proofs/src/dev/cost.rs:328:33 | 328 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/poly.rs#L174
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/poly.rs:174:22 | 174 | .zip(inv_denoms.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `inv_denoms` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/202008a1b8de96d2e5b6bc02d379db03a877d34d/library/core/src/iter/traits/iterator.rs:589:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
this bound is already specified as the supertrait of `ExactSizeIterator`: halo2_proofs/src/poly.rs#L167
warning: this bound is already specified as the supertrait of `ExactSizeIterator` --> halo2_proofs/src/poly.rs:167:26 | 167 | inv_denoms: impl Iterator<Item = F> + ExactSizeIterator, | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls = note: `-W clippy::implied-bounds-in-impls` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::implied_bounds_in_impls)]` help: try removing this bound | 167 - inv_denoms: impl Iterator<Item = F> + ExactSizeIterator, 167 + inv_denoms: impl ExactSizeIterator<Item = F>, |
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/poly.rs#L159
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/poly.rs:159:14 | 159 | .zip(assigned_denominators.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `assigned_denominators` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/202008a1b8de96d2e5b6bc02d379db03a877d34d/library/core/src/iter/traits/iterator.rs:589:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
the following explicit lifetimes could be elided: 'a: halo2_proofs/src/poly/multiopen/prover.rs#L125
warning: the following explicit lifetimes could be elided: 'a --> halo2_proofs/src/poly/multiopen/prover.rs:125:6 | 125 | impl<'a, C: CurveAffine> PartialEq for PolynomialPointer<'a, C> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 125 - impl<'a, C: CurveAffine> PartialEq for PolynomialPointer<'a, C> { 125 + impl<C: CurveAffine> PartialEq for PolynomialPointer<'_, C> { |
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/poly/multiopen/prover.rs#L105
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/poly/multiopen/prover.rs:105:58 | 105 | let (p_poly, p_poly_blind) = q_polys.into_iter().zip(q_blinds.into_iter()).fold( | ^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `q_blinds` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/202008a1b8de96d2e5b6bc02d379db03a877d34d/library/core/src/iter/traits/iterator.rs:589:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
use of `default` to create a unit struct: halo2_proofs/src/poly/evaluator.rs#L124
warning: use of `default` to create a unit struct --> halo2_proofs/src/poly/evaluator.rs:124:36 | 124 | _evaluator: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: halo2_proofs/src/poly/evaluator.rs#L78
warning: use of `default` to create a unit struct --> halo2_proofs/src/poly/evaluator.rs:78:36 | 78 | _evaluator: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `-W clippy::default-constructed-unit-structs` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::default_constructed_unit_structs)]`
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/plonk/verifier.rs#L319
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/verifier.rs:319:25 | 319 | / lookups 320 | | .iter() 321 | | .flat_map(move |p| p.queries(vk, x)) 322 | | .into_iter(), | |________________________________________^ | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/202008a1b8de96d2e5b6bc02d379db03a877d34d/library/core/src/iter/traits/iterator.rs:471:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing the `.into_iter()` | 319 ~ lookups 320 + .iter() 321 ~ .flat_map(move |p| p.queries(vk, x)), |
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/plonk/verifier.rs#L259
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/verifier.rs:259:25 | 259 | / lookups 260 | | .iter() 261 | | .zip(vk.cs.lookups.iter()) 262 | | .flat_map(move |(p, argument)| { ... | 275 | | }) 276 | | .into_iter(), | |________________________________________^ | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/202008a1b8de96d2e5b6bc02d379db03a877d34d/library/core/src/iter/traits/iterator.rs:471:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing the `.into_iter()` | 259 ~ lookups 260 + .iter() 261 + .zip(vk.cs.lookups.iter()) 262 + .flat_map(move |(p, argument)| { 263 + p.expressions( 264 + l_0, 265 + l_last, 266 + l_blind, 267 + argument, 268 + theta, 269 + beta, 270 + gamma, 271 + advice_evals, 272 + fixed_evals, 273 + instance_evals, 274 + ) 275 ~ }), |
the borrowed expression implements the required traits: halo2_proofs/src/plonk/verifier.rs#L206
warning: the borrowed expression implements the required traits --> halo2_proofs/src/plonk/verifier.rs:206:24 | 206 | let xn = x.pow(&[params.n, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[params.n, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/plonk/prover.rs#L707
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/prover.rs:707:24 | 707 | .chain(lookups.iter().flat_map(move |p| p.open(pk, x)).into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `lookups.iter().flat_map(move |p| p.open(pk, x))` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/202008a1b8de96d2e5b6bc02d379db03a877d34d/library/core/src/iter/traits/iterator.rs:471:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
the borrowed expression implements the required traits: halo2_proofs/src/plonk/prover.rs#L599
warning: the borrowed expression implements the required traits --> halo2_proofs/src/plonk/prover.rs:599:20 | 599 | let xn = x.pow(&[params.n, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[params.n, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/plonk/prover.rs#L581
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/prover.rs:581:28 | 581 | .chain(permutation_expressions.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `permutation_expressions` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/202008a1b8de96d2e5b6bc02d379db03a877d34d/library/core/src/iter/traits/iterator.rs:471:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/plonk/prover.rs#L547
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/prover.rs:547:14 | 547 | .zip(lookup_expressions.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `lookup_expressions` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/202008a1b8de96d2e5b6bc02d379db03a877d34d/library/core/src/iter/traits/iterator.rs:589:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/plonk/prover.rs#L546
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/prover.rs:546:14 | 546 | .zip(permutation_expressions.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `permutation_expressions` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/202008a1b8de96d2e5b6bc02d379db03a877d34d/library/core/src/iter/traits/iterator.rs:589:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
the following explicit lifetimes could be elided: 'a: halo2_proofs/src/plonk/prover.rs#L147
warning: the following explicit lifetimes could be elided: 'a --> halo2_proofs/src/plonk/prover.rs:147:18 | 147 | impl<'a, F: Field> Assignment<F> for WitnessCollection<'a, F> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 147 - impl<'a, F: Field> Assignment<F> for WitnessCollection<'a, F> { 147 + impl<F: Field> Assignment<F> for WitnessCollection<'_, F> { |
doc list item without indentation: halo2_proofs/src/plonk/lookup/prover.rs#L562
warning: doc list item without indentation --> halo2_proofs/src/plonk/lookup/prover.rs:562:5 | 562 | /// This method returns (A', S') if no errors are encountered. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 562 | /// This method returns (A', S') if no errors are encountered. | ++
doc list item without indentation: halo2_proofs/src/plonk/lookup/prover.rs#L74
warning: doc list item without indentation --> halo2_proofs/src/plonk/lookup/prover.rs:74:9 | 74 | /// The Permuted<C> struct is used to update the Lookup, and is then returned. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation = note: `-W clippy::doc-lazy-continuation` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::doc_lazy_continuation)]` help: indent this line | 74 | /// The Permuted<C> struct is used to update the Lookup, and is then returned. | ++
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/plonk/circuit.rs#L1261
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/circuit.rs:1261:22 | 1261 | .zip(degrees.into_iter()) | ^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `degrees` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/202008a1b8de96d2e5b6bc02d379db03a877d34d/library/core/src/iter/traits/iterator.rs:589:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
the following explicit lifetimes could be elided: 'a: halo2_proofs/src/plonk/circuit.rs#L988
warning: the following explicit lifetimes could be elided: 'a --> halo2_proofs/src/plonk/circuit.rs:988:6 | 988 | impl<'a, F: Field> std::fmt::Debug for PinnedGates<'a, F> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 988 - impl<'a, F: Field> std::fmt::Debug for PinnedGates<'a, F> { 988 + impl<F: Field> std::fmt::Debug for PinnedGates<'_, F> { |
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/plonk/circuit.rs#L893
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/circuit.rs:893:18 | 893 | .zip(self.constraints.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `self.constraints` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/202008a1b8de96d2e5b6bc02d379db03a877d34d/library/core/src/iter/traits/iterator.rs:589:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-W clippy::useless-conversion` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::useless_conversion)]`
the following explicit lifetimes could be elided: 'r: halo2_proofs/src/circuit.rs#L380
warning: the following explicit lifetimes could be elided: 'r --> halo2_proofs/src/circuit.rs:380:6 | 380 | impl<'r, F: Field> Table<'r, F> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 380 - impl<'r, F: Field> Table<'r, F> { 380 + impl<F: Field> Table<'_, F> { |
the following explicit lifetimes could be elided: 'r: halo2_proofs/src/circuit.rs#L191
warning: the following explicit lifetimes could be elided: 'r --> halo2_proofs/src/circuit.rs:191:6 | 191 | impl<'r, F: Field> Region<'r, F> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 191 - impl<'r, F: Field> Region<'r, F> { 191 + impl<F: Field> Region<'_, F> { |
the following explicit lifetimes could be elided: 'r: halo2_proofs/src/circuit/table_layouter.rs#L67
warning: the following explicit lifetimes could be elided: 'r --> halo2_proofs/src/circuit/table_layouter.rs:67:6 | 67 | impl<'r, 'a, F: Field, CS: Assignment<F> + 'a> TableLayouter<F> | ^^ 68 | for SimpleTableLayouter<'r, 'a, F, CS> | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 67 ~ impl<'a, F: Field, CS: Assignment<F> + 'a> TableLayouter<F> 68 ~ for SimpleTableLayouter<'_, 'a, F, CS> |
the following explicit lifetimes could be elided: 'r: halo2_proofs/src/circuit/table_layouter.rs#L48
warning: the following explicit lifetimes could be elided: 'r --> halo2_proofs/src/circuit/table_layouter.rs:48:6 | 48 | impl<'r, 'a, F: Field, CS: Assignment<F> + 'a> fmt::Debug for SimpleTableLayouter<'r, 'a, F, CS> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 48 - impl<'r, 'a, F: Field, CS: Assignment<F> + 'a> fmt::Debug for SimpleTableLayouter<'r, 'a, F, CS> { 48 + impl<'a, F: Field, CS: Assignment<F> + 'a> fmt::Debug for SimpleTableLayouter<'_, 'a, F, CS> { |
the following explicit lifetimes could be elided: 'r: halo2_proofs/src/circuit/floor_planner/v1.rs#L363
warning: the following explicit lifetimes could be elided: 'r --> halo2_proofs/src/circuit/floor_planner/v1.rs:363:6 | 363 | impl<'r, 'a, F: Field, CS: Assignment<F> + 'a> RegionLayouter<F> for V1Region<'r, 'a, F, CS> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 363 - impl<'r, 'a, F: Field, CS: Assignment<F> + 'a> RegionLayouter<F> for V1Region<'r, 'a, F, CS> { 363 + impl<'a, F: Field, CS: Assignment<F> + 'a> RegionLayouter<F> for V1Region<'_, 'a, F, CS> { |
the following explicit lifetimes could be elided: 'r: halo2_proofs/src/circuit/floor_planner/v1.rs#L348
warning: the following explicit lifetimes could be elided: 'r --> halo2_proofs/src/circuit/floor_planner/v1.rs:348:6 | 348 | impl<'r, 'a, F: Field, CS: Assignment<F> + 'a> fmt::Debug for V1Region<'r, 'a, F, CS> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 348 - impl<'r, 'a, F: Field, CS: Assignment<F> + 'a> fmt::Debug for V1Region<'r, 'a, F, CS> { 348 + impl<'a, F: Field, CS: Assignment<F> + 'a> fmt::Debug for V1Region<'_, 'a, F, CS> { |
the following explicit lifetimes could be elided: 'p: halo2_proofs/src/circuit/floor_planner/v1.rs#L163
warning: the following explicit lifetimes could be elided: 'p --> halo2_proofs/src/circuit/floor_planner/v1.rs:163:6 | 163 | impl<'p, 'a, F: Field, CS: Assignment<F> + 'a> Layouter<F> for V1Pass<'p, 'a, F, CS> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 163 - impl<'p, 'a, F: Field, CS: Assignment<F> + 'a> Layouter<F> for V1Pass<'p, 'a, F, CS> { 163 + impl<'a, F: Field, CS: Assignment<F> + 'a> Layouter<F> for V1Pass<'_, 'a, F, CS> { |
the following explicit lifetimes could be elided: 'r: halo2_proofs/src/circuit/floor_planner/single_pass.rs#L246
warning: the following explicit lifetimes could be elided: 'r --> halo2_proofs/src/circuit/floor_planner/single_pass.rs:246:6 | 246 | impl<'r, 'a, F: Field, CS: Assignment<F> + 'a> RegionLayouter<F> | ^^ 247 | for SingleChipLayouterRegion<'r, 'a, F, CS> | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 246 ~ impl<'a, F: Field, CS: Assignment<F> + 'a> RegionLayouter<F> 247 ~ for SingleChipLayouterRegion<'_, 'a, F, CS> |
the following explicit lifetimes could be elided: 'r: halo2_proofs/src/circuit/floor_planner/single_pass.rs#L225
warning: the following explicit lifetimes could be elided: 'r --> halo2_proofs/src/circuit/floor_planner/single_pass.rs:225:6 | 225 | impl<'r, 'a, F: Field, CS: Assignment<F> + 'a> fmt::Debug | ^^ 226 | for SingleChipLayouterRegion<'r, 'a, F, CS> | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `-W clippy::needless-lifetimes` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_lifetimes)]` help: elide the lifetimes | 225 ~ impl<'a, F: Field, CS: Assignment<F> + 'a> fmt::Debug 226 ~ for SingleChipLayouterRegion<'_, 'a, F, CS> |
struct `PointIndex` is never constructed: halo2_proofs/src/plonk/circuit.rs#L769
warning: struct `PointIndex` is never constructed --> halo2_proofs/src/plonk/circuit.rs:769:19 | 769 | pub(crate) struct PointIndex(pub usize); | ^^^^^^^^^^
trait `IndexedParallelIterator` is never used: halo2_proofs/src/multicore.rs#L28
warning: trait `IndexedParallelIterator` is never used --> halo2_proofs/src/multicore.rs:28:11 | 28 | pub trait IndexedParallelIterator: std::iter::Iterator {} | ^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
unused doc comment: halo2_proofs/src/dev/cost.rs#L109
warning: unused doc comment --> halo2_proofs/src/dev/cost.rs:109:13 | 109 | /// Selector assignments used for optimization pass | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 110 | selectors: vec![vec![false; n]; num_selectors], | ---------------------------------------------- rustdoc does not generate documentation for expression fields | = help: use `//` for a plain comment
unused doc comment: halo2_proofs/src/dev/cost.rs#L107
warning: unused doc comment --> halo2_proofs/src/dev/cost.rs:107:13 | 107 | /// Pairs of cells between which we have equality constraints. | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 108 | equality: vec![], | ---------------- rustdoc does not generate documentation for expression fields | = help: use `//` for a plain comment
unused doc comment: halo2_proofs/src/dev/cost.rs#L105
warning: unused doc comment --> halo2_proofs/src/dev/cost.rs:105:13 | 105 | /// Any cells assigned outside of a region. | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 106 | loose_cells: vec![], | ------------------- rustdoc does not generate documentation for expression fields | = help: use `//` for a plain comment = note: `#[warn(unused_doc_comments)]` on by default
unused imports: `ParallelIterator` and `Scope`: halo2_proofs/src/multicore.rs#L15
warning: unused imports: `ParallelIterator` and `Scope` --> halo2_proofs/src/multicore.rs:15:34 | 15 | iter::{IntoParallelIterator, ParallelIterator}, | ^^^^^^^^^^^^^^^^ 16 | join, scope, Scope, | ^^^^^ | = note: `#[warn(unused_imports)]` on by default
Bitrot check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Bitrot check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Bitrot check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Bitrot check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Bitrot check
virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"`
Bitrot check: halo2_proofs/src/multicore.rs#L16
unused import: `Scope`
Bitrot check: halo2_proofs/src/dev/cost.rs#L105
unused doc comment
Bitrot check: halo2_proofs/src/dev/cost.rs#L107
unused doc comment
Bitrot check: halo2_proofs/src/dev/cost.rs#L109
unused doc comment
Bitrot check: halo2_proofs/src/plonk/circuit.rs#L769
struct `PointIndex` is never constructed
Bitrot check
`halo2_proofs` (lib) generated 5 warnings (run `cargo fix --lib -p halo2_proofs` to apply 1 suggestion)
Bitrot check: halo2_poseidon/src/test_vectors.rs#L3
struct `PermuteTestVector` is never constructed
Bitrot check: halo2_poseidon/src/test_vectors.rs#L8
struct `HashTestVector` is never constructed
Bitrot check: halo2_poseidon/src/test_vectors.rs#L16
function `permute` is never used
Book tests
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Book tests
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Book tests
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Book tests
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Book tests: halo2_poseidon/src/test_vectors.rs#L3
struct is never constructed: `PermuteTestVector`
Book tests: halo2_poseidon/src/test_vectors.rs#L8
struct is never constructed: `HashTestVector`
Book tests: halo2_poseidon/src/test_vectors.rs#L16
function is never used: `permute`
Book tests: halo2_poseidon/src/test_vectors.rs#L420
function is never used: `hash`
Book tests: halo2_poseidon/src/test_vectors.rs#L641
function is never used: `permute`
Book tests: halo2_poseidon/src/test_vectors.rs#L1045
function is never used: `hash`
Book tests
`halo2_poseidon` (lib) generated 6 warnings
Book tests: halo2_gadgets/src/poseidon.rs#L3
unused import: `std::convert::TryInto`
Book tests
`halo2_gadgets` (lib) generated 1 warning
Intra-doc links
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Intra-doc links
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Intra-doc links
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Intra-doc links
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Intra-doc links: halo2_poseidon/src/test_vectors.rs#L3
struct is never constructed: `PermuteTestVector`
Intra-doc links: halo2_poseidon/src/test_vectors.rs#L8
struct is never constructed: `HashTestVector`
Intra-doc links: halo2_poseidon/src/test_vectors.rs#L16
function is never used: `permute`
Intra-doc links: halo2_poseidon/src/test_vectors.rs#L420
function is never used: `hash`
Intra-doc links: halo2_poseidon/src/test_vectors.rs#L641
function is never used: `permute`
Intra-doc links: halo2_poseidon/src/test_vectors.rs#L1045
function is never used: `hash`
Intra-doc links
`halo2_poseidon` (lib) generated 6 warnings
Intra-doc links: halo2_poseidon/src/test_vectors.rs#L1
unresolved link to `OrchardNullifier`
Intra-doc links
`halo2_poseidon` (lib doc) generated 1 warning
Test on macOS-latest with nightly features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on macOS-latest with nightly features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on macOS-latest with nightly features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on macOS-latest with nightly features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on macOS-latest with nightly features
build failed, waiting for other jobs to finish...
Test on macOS-latest with beta features
build failed, waiting for other jobs to finish...
Build target wasm32-wasi
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build target wasm32-wasi
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build target wasm32-wasi
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build target wasm32-wasi
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build target wasm32-wasi: halo2_poseidon/src/test_vectors.rs#L3
struct is never constructed: `PermuteTestVector`
Build target wasm32-wasi: halo2_poseidon/src/test_vectors.rs#L8
struct is never constructed: `HashTestVector`
Build target wasm32-wasi: halo2_poseidon/src/test_vectors.rs#L16
function is never used: `permute`
Build target wasm32-wasi: halo2_poseidon/src/test_vectors.rs#L420
function is never used: `hash`
Build target wasm32-wasi: halo2_poseidon/src/test_vectors.rs#L641
function is never used: `permute`
Build target wasm32-wasi: halo2_poseidon/src/test_vectors.rs#L1045
function is never used: `hash`
Build target wasm32-wasi
`halo2_poseidon` (lib) generated 6 warnings
Build target wasm32-wasi: halo2_gadgets/src/poseidon.rs#L3
unused import: `std::convert::TryInto`
Build target wasm32-wasi
`halo2_gadgets` (lib) generated 1 warning
Build target wasm32-unknown-unknown: halo2_poseidon/src/test_vectors.rs#L3
struct is never constructed: `PermuteTestVector`
Build target wasm32-unknown-unknown: halo2_poseidon/src/test_vectors.rs#L8
struct is never constructed: `HashTestVector`
Build target wasm32-unknown-unknown: halo2_poseidon/src/test_vectors.rs#L16
function is never used: `permute`
Build target wasm32-unknown-unknown: halo2_poseidon/src/test_vectors.rs#L641
function is never used: `permute`
Build target wasm32-unknown-unknown
`halo2_poseidon` (lib) generated 6 warnings
Build target wasm32-unknown-unknown: halo2_gadgets/src/poseidon.rs#L3
unused import: `std::convert::TryInto`
Code coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Code coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Code coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Code coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Code coverage
virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"`
Test on i686-unknown-linux-gnu with nightly features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on i686-unknown-linux-gnu with nightly features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on i686-unknown-linux-gnu with nightly features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on i686-unknown-linux-gnu with nightly features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/