Add AdVerification Extension #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
conceptually looks ok - there are these github action failures we need to sort out - but 👍 |
|
Something weird: tests are failing even on vast 4 branch. Difference is: in this branch it has go.sum and in vast 4 it only has go.mod For tests difference is: when we convert vast to json it adds xml.Name field with empty values to result |
|
Fixed by adding missing xml.Name values (should be VAST) |
milos-pesic-zattoo
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to standard before VAST 4.1 AdVerification data can be provided as Extension
https://s3-us-west-2.amazonaws.com/omsdk-demo-files/docs/OMID_API_v1.2.pdf
This PR adds AdVerifications field to Extensions in a way similar to CustomTracking.