refactor: normal creator #3114
Open
refactor: normal creator #3114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for zarf-docs canceled.
|
phillebaba
force-pushed
the
refactor/creator-normal
branch
from
ae6c1dc to
6dbbc6b
Compare
phillebaba
force-pushed
the
refactor/creator-normal
branch
7 times, most recently
from
47c5dd1 to
5b54240
Compare
phillebaba
force-pushed
the
refactor/creator-normal
branch
9 times, most recently
from
cbd05e3 to
ca69d35
Compare
phillebaba
force-pushed
the
refactor/creator-normal
branch
6 times, most recently
from
3c36c9d to
4a829c6
Compare
phillebaba
force-pushed
the
refactor/creator-normal
branch
from
4a829c6 to
8cd0d1c
Compare
phillebaba
commented
Nov 5, 2024
| for idx, component := range pkg.Components { | ||
| pkg.Components[idx], _ = deprecated.MigrateComponent(pkg.Build, component) | ||
| } | ||
| // TODO (phillebaba): Figure out when migrations should actually be run. |
phillebaba
force-pushed
the
refactor/creator-normal
branch
from
8cd0d1c to
673af5f
Compare
phillebaba
force-pushed
the
refactor/creator-normal
branch
11 times, most recently
from
60a658b to
dcd8b19
Compare
phillebaba
force-pushed
the
refactor/creator-normal
branch
4 times, most recently
from
805199a to
8bf8990
Compare
|
Generally looks good. I do request that we keep the I know we're trying to limit output for non errors, but I think the package tar path is worth logging since the filename isn't intuitive. It's a combination of whether it's an init or package config, amd or arm64, and the version. As a user I've found it useful to copy + paste the name from terminal when my next step is to publish or deploy, especially when I have multiple packages in the same directory. |
phillebaba
force-pushed
the
refactor/creator-normal
branch
2 times, most recently
from
08cf981 to
ad7f12a
Compare
Signed-off-by: Philip Laine <[email protected]>
phillebaba
force-pushed
the
refactor/creator-normal
branch
from
ad7f12a to
49f5112
Compare
|
I have now added back the logging for the path the package is saved to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change refactors the package creation.
Related Issue
Relates to #2969
Checklist before merging