Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify deployment #418

Merged
merged 6 commits into from
Jun 11, 2024
Merged

Simplify deployment #418

merged 6 commits into from
Jun 11, 2024

Conversation

mgruner
Copy link
Collaborator

@mgruner mgruner commented Jun 10, 2024

  • Improve handling of default values
    • Move them to default interpolation values in the YAML file. This makes it possible to deploy without any .env file that needs to be maintained (if the default values are good enough, e.g. for testing), while being backwards compatible.
  • Improve handling of NGINX port configuration
    • Make proper use of the existing NGINX_PORT variable (for expose) and add a new NGINX_EXPOSE_PORT variable that controls the exposed port of the application.
  • Improve customization handling
    • nginx port settings were moved to the main configuration file, so that the docker-compose.override.yml could be removed from the git repository. This allows for local customizations with that file in the same way as before, without having conflicts from git or other updates by file overwrites.
  • Improve backup handling
    • The backup script was moved to the zammad image with 6.3.1-38. Use that instead via the docker entrypoint, so that no separate custom mount is necessary.

This greatly simplifies the deployment e.g. via Portainer, where now a deployment directly from git is possible just by entering the project URL, no ENVs have to be specified. Customizations via ENV and custom YAML files is possible just like before.

@mgruner mgruner requested a review from monotek June 10, 2024 10:32
@mgruner mgruner marked this pull request as ready for review June 10, 2024 10:32
@mgruner mgruner changed the title Simplify ENV handling by using default values in the YAML Simplify deployment Jun 11, 2024
@mgruner mgruner merged commit e7b21d3 into master Jun 11, 2024
4 checks passed
@mgruner mgruner deleted the simplify-env-handling branch June 11, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants