Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes: #379 - Add mount point for /opt/zammad/storage #380

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

mgruner
Copy link
Collaborator

@mgruner mgruner commented Sep 27, 2023

It will not hurt to have this mount point, even if it is not used by default. Instead, it will make maintenance easier.

MrGeneration
MrGeneration previously approved these changes Sep 27, 2023
Copy link
Member

@MrGeneration MrGeneration left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from my one concern the rest is looking good to me.

docker-compose.yml Outdated Show resolved Hide resolved
Copy link
Member

@MrGeneration MrGeneration left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

@mgruner mgruner merged commit 07936ea into master Sep 27, 2023
4 checks passed
@mgruner mgruner deleted the zammad-storage-mount branch September 27, 2023 11:47
@seljuck
Copy link

seljuck commented Oct 31, 2023

If we are upgrading from 5.3 where the docker-compose file has already created
zammad-data:/opt/zammad

and we use the new docker-compose that uses
zammad-storage:/opt/zammad/storage

Will this cause us to lose any data, if we don't add zammad-data back to the compose file?

@mgruner
Copy link
Collaborator Author

mgruner commented Nov 2, 2023

If you find that data is missing, you can temporarily re-add the previous mount point, and move the data to the new location.

@seljuck
Copy link

seljuck commented Nov 2, 2023

Thanks for the answer. I gave it a try without re-adding it. It looks like all our data is still there.

floriankessler pushed a commit to floriankessler/zammad-docker-compose that referenced this pull request Jan 5, 2024
)

* Closes: zammad#379 - Add mount point for /opt/zammad/storage

* Remove zammad-storage from nginx container again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants