Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #336 - Added rails commands for setting a channel to trusted #337

Merged
merged 3 commits into from
Sep 18, 2023
Merged

Fixes #336 - Added rails commands for setting a channel to trusted #337

merged 3 commits into from
Sep 18, 2023

Conversation

ralf401
Copy link
Contributor

@ralf401 ralf401 commented Sep 18, 2023

No description provided.

@ralf401 ralf401 self-assigned this Sep 18, 2023
@ralf401 ralf401 requested a review from mgruner September 18, 2023 07:14
@ralf401
Copy link
Contributor Author

ralf401 commented Sep 18, 2023

@mgruner can you have a look? Thanks!!

@ralf401 ralf401 linked an issue Sep 18, 2023 that may be closed by this pull request
Add console commands for trusted channels #336
Closed
mgruner
mgruner approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@mgruner mgruner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but saving is still missing and needs to be corrected.

@ralf401 ralf401 merged commit 8e371c1 into pre-release Sep 18, 2023
1 check passed
@ralf401 ralf401 deleted the rsc/fixes/336/rails-trusted-channels branch September 18, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgruner mgruner mgruner approved these changes

Assignees

@ralf401 ralf401

Labels
📚documentation📚
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add console commands for trusted channels
2 participants
@ralf401 @mgruner